Deprecate __version__ attribute#897
Merged
Secrus merged 1 commit intopython-pendulum:masterfrom Apr 23, 2025
Merged
Conversation
__version__ attribute
14cc5f0 to
c948248
Compare
CodSpeed Performance ReportMerging #897 will not alter performanceComparing Summary
|
ashb
approved these changes
Apr 22, 2025
Member
ashb
left a comment
There was a problem hiding this comment.
I kind of like having __version__ attrs in there, as importlib.metadata is surprisingly slow, but I guess not much should really be looking at version anyway
Collaborator
Author
Looking at version shouldn't be something one does too often, and I prefer we have a single (or rather reduce from 3 to 2) source of version. |
c948248 to
a151d1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Check List