Do not raise error from unknown channel id when parsing PSD layers#9644
Open
radarhere wants to merge 2 commits into
Open
Do not raise error from unknown channel id when parsing PSD layers#9644radarhere wants to merge 2 commits into
radarhere wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Within a PSD layer, it is possible that an unsupported channel ID will trigger an
IndexError.Pillow/src/PIL/PsdImagePlugin.py
Lines 224 to 232 in ee9e761
However, Pillow has already established that if the combination of channels don't lead to a recognised mode, that's not cause for an error.
Pillow/src/PIL/PsdImagePlugin.py
Lines 235 to 244 in ee9e761
This PR applies that same logic to the first step, since conceptually, not knowing what type of data is in a band is a subset of not knowing what mode the overall layer is.