Preserve split package metadata in sdists - #47
Merged
Conversation
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
Contributor
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #47 +/- ##
===========================================
- Coverage 82.20% 72.15% -10.05%
===========================================
Files 7 7
Lines 118 176 +58
===========================================
+ Hits 97 127 +30
- Misses 21 49 +28 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split sdists currently rebuild as the base package because Hatchling resolves dynamic dependencies from
PKG-INFOand skips metadata hooks. Register an sdist build hook that packagespyproject.tomlwith the generated split-package name so downstream wheels retain the selected extra and dependency.Document the required sdist hook configuration and add an end-to-end sdist-to-wheel regression test.
Type of Change
Checklist
make lint)make test)