Merged
Conversation
Member
Author
|
pre-commit.ci autofix |
Member
Author
|
@hansthen I'd love your help with the mypy failure here. |
Collaborator
The issue is upstream in Branca. The offending code returns I was able to get rid of the error using this: However, Branca does not use much typing so far. Let me check if there is a better way. |
(and removed unused typing info from function body)
Collaborator
|
I could not get typing to work without either changing |
Collaborator
|
I think just disabling typing for this line here is okay. I also removed some unused typing info (in the body of an untyped function) because it triggered a warning. |
Member
Author
|
Thanks! Please merge I'd you are happy with this PR. |
hansthen
added a commit
to hansthen/folium
that referenced
this pull request
Nov 2, 2025
* enforce py39 min * fix all lints * Fix mypy error messages (and removed unused typing info from function body) --------- Co-authored-by: Hans Then <hans.then@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should help with #2167