-
-
Notifications
You must be signed in to change notification settings - Fork 34k
[3.14] gh-144330: Initialize classmethod and staticmethod in new #144498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Initialize cm_callable and sm_callable to None in classmethod and staticmethod constructor. Co-authored-by: Aniket Singh Yadav <singhyadavaniket43@gmail.com>
|
"Tests / Change detection / Create context from changed files" fails with: I don't know why. |
|
Maybe a GH outage, it sets |
|
I hope you don't mind if I ask :) |
|
I tried it again, still Edit: that worked, though I still wonder why it occurred in the first place... GitHub doing its thing 🙃 |
Correct. The change ffa6852 introduces behavior changes, such as: |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
pythonGH-144498) pythongh-144330: Initialize classmethod and staticmethod in new Initialize cm_callable and sm_callable to None in classmethod and staticmethod constructor. (cherry picked from commit 160810d) Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Aniket Singh Yadav <singhyadavaniket43@gmail.com> Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
|
GH-144537 is a backport of this pull request to the 3.13 branch. |
|
@vstinner Thanks! |
…144498) (#144537) [3.14] gh-144330: Initialize classmethod and staticmethod in new (GH-144498) gh-144330: Initialize classmethod and staticmethod in new Initialize cm_callable and sm_callable to None in classmethod and staticmethod constructor. (cherry picked from commit 160810d) Co-authored-by: Victor Stinner <vstinner@python.org> Co-authored-by: Aniket Singh Yadav <singhyadavaniket43@gmail.com> Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
@StanFromIreland GH updates the ephemeral PR merge pointer on certain events (like pushing a new commit). When there's outages, these events aren't delivered to the respective components, which may cause PR state to go out of sync. Once the outage is over, pushing again should generally fix it, but on a rare occasion GH's internal state is so broken that nothing can salvage it — in such cases the only solution would be creating a new PR. |
Initialize cm_callable and sm_callable to None in classmethod and staticmethod constructor.
classmethodandstaticmethodcan crash withNULL/ uninitialized callables #144330