-
-
Notifications
You must be signed in to change notification settings - Fork 34.1k
gh-144473: Add "steal" term to glossary; clarify "stealing" on error #144502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
With one exception, all "stealing" functions also steal on error, but it makes sense to note this in each case.
Co-authored-by: Peter Bierma <[email protected]>
Noted. |
|
I wasn't aware of that discussion. Thanks for the tip. I'm still not convinced that putting quotation marks around it is the right approach; these are scare quotes, which are used for ideas that are disputed or skeptical, so I think it's a bit of a contradiction to put scare quotes around "steal" when we seem to have coined the term. It makes us seem like we don't trust the term or are taking it from somewhere else, which isn't true, unless I'm missing some history here. |
|
AFAIK, “we” minted it but the few-decades-older “we” don't like the term any more. I personally think the term is fine (“transfer ownership” is better, but too unwieldy). But that means I need to be careful :) |
Yeah, that's fine, but this PR does add quotes in places where there weren't quotes before. |
|
Yes, it makes all references use the same style. |
|
Would it be okay to keep things the same style here, and only add the link? The rest of the PR looks good to me otherwise. |
|
Since the term is added to the glossary, I don't think that it's worth it to put it in quotes. |
|
I spent some time reconciling this with capi-workgroup/problems#11, and ended up with a slightly different reason for putting the term in quotes. Think of it as a placeholder; a TODO. The proper term is transfer ownership. But, defining ownership is a larger change, since I'd like to not limit it to Here's a draft: main...encukou:cpython:ownership-docs#diff-dfb52ee6e68075f904da6e69ed1799c5cbf1185c279968a807787d69ae2e8cf5R1152 I'd prefer putting this smaller imperfect (and quote-ful) change in now, but, well, it can wait for a rewrite. |
📚 Documentation preview 📚: https://cpython-previews--144502.org.readthedocs.build/