Skip to content

gh-154144: Fix false positive from the stdbool.h guard in _testcapimodule.c#154145

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:testcapi-stdbool-guard
Jul 19, 2026
Merged

gh-154144: Fix false positive from the stdbool.h guard in _testcapimodule.c#154145
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:testcapi-stdbool-guard

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jul 19, 2026

Copy link
Copy Markdown
Member

Move the guard above the system includes: NetBSD's <sys/sysctl.h> includes <stdbool.h>. Also correct the issue reference (gh-90904, not gh-48924).

🤖 Generated with Claude Code

…capimodule.c

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@encukou encukou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable. Thanks!

@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jul 19, 2026
@serhiy-storchaka
serhiy-storchaka merged commit 8d11eb0 into python:main Jul 19, 2026
68 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@serhiy-storchaka
serhiy-storchaka deleted the testcapi-stdbool-guard branch July 19, 2026 15:06
@bedevere-app

bedevere-app Bot commented Jul 19, 2026

Copy link
Copy Markdown

GH-154157 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 19, 2026
@bedevere-app

bedevere-app Bot commented Jul 19, 2026

Copy link
Copy Markdown

GH-154158 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jul 19, 2026
@bedevere-app

bedevere-app Bot commented Jul 19, 2026

Copy link
Copy Markdown

GH-154159 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jul 19, 2026
serhiy-storchaka added a commit that referenced this pull request Jul 19, 2026
…tcapimodule.c (GH-154145) (GH-154159)

(cherry picked from commit 8d11eb0)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
serhiy-storchaka added a commit that referenced this pull request Jul 19, 2026
…tcapimodule.c (GH-154145) (GH-154158)

(cherry picked from commit 8d11eb0)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
serhiy-storchaka added a commit that referenced this pull request Jul 19, 2026
…tcapimodule.c (GH-154145) (GH-154157)

(cherry picked from commit 8d11eb0)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants