Skip to content

gh-154303: Skip test_sqlite3 CLI completion tests on OpenBSD#154304

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:openbsd-sqlite3-completion-skip
Jul 20, 2026
Merged

gh-154303: Skip test_sqlite3 CLI completion tests on OpenBSD#154304
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:openbsd-sqlite3-completion-skip

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Jul 20, 2026

Copy link
Copy Markdown
Member

OpenBSD's readline does not honor completion-query-items 0, so completing many candidates blocks on a "Display all N? (y or n)" prompt that hangs the pseudo-terminal opened by run_pty(). Skip the whole Completion class on OpenBSD, like the existing libedit skip.

OpenBSD's readline does not honor "completion-query-items 0", so completing
many candidates blocks on a "Display all N?" prompt that hangs the
pseudo-terminal opened by run_pty().  Skip the whole Completion class on
OpenBSD, like the existing libedit skip.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Jul 20, 2026
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes skip news labels Jul 20, 2026
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) July 20, 2026 21:43
@serhiy-storchaka
serhiy-storchaka merged commit 63b564f into python:main Jul 20, 2026
59 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@miss-islington-app

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 63b564fc8728036f165805407f7d2b4e8bfd3ef0 3.14

@bedevere-app

bedevere-app Bot commented Jul 20, 2026

Copy link
Copy Markdown

GH-154305 is a backport of this pull request to the 3.15 branch.

@miss-islington-app

Copy link
Copy Markdown

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 63b564fc8728036f165805407f7d2b4e8bfd3ef0 3.13

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jul 20, 2026
@serhiy-storchaka
serhiy-storchaka deleted the openbsd-sqlite3-completion-skip branch July 20, 2026 22:10
@serhiy-storchaka serhiy-storchaka removed needs backport to 3.14 bugs and security fixes needs backport to 3.13 bugs and security fixes labels Jul 20, 2026
@serhiy-storchaka serhiy-storchaka removed their assignment Jul 20, 2026
serhiy-storchaka added a commit that referenced this pull request Jul 21, 2026
…H-154304) (GH-154305)

OpenBSD's readline does not honor "completion-query-items 0", so completing
many candidates blocks on a "Display all N?" prompt that hangs the
pseudo-terminal opened by run_pty().  Skip the whole Completion class on
OpenBSD, like the existing libedit skip.
(cherry picked from commit 63b564f)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant