gh-154359: Optimize UserList type checks to use list directly#154358
Closed
pranavchoudhary-tech wants to merge 4 commits into
Closed
gh-154359: Optimize UserList type checks to use list directly#154358pranavchoudhary-tech wants to merge 4 commits into
pranavchoudhary-tech wants to merge 4 commits into
Conversation
Contributor
Author
|
Could a maintainer please apply the |
Member
|
Performance improvements must always be backed by benchmarks. I don't see value in this proposal for a class that is not used a lot and where this change could have broken existing code elsewhere (the attribute is still public). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR optimizes the type checking within
UserListinside thecollectionsmodule.Since
self.datais hardcoded to be an empty list[]at the beginning ofUserList.__init__, the expressiontype(self.data)will always evaluate to thelisttype. We can replacetype(initlist) == type(self.data)with a direct and more idiomatictype(initlist) is listidentity check, bypassing the unnecessarytype()call and attribute lookup while avoiding the slight anti-pattern of using the==operator to compare singleton type objects. The same optimization applies to the__add__,__radd__, and__iadd__magic methods.I ran the
test_collectionssuite and verified that everything passes successfully with these changes.Fixes #154359