Conversation
jhance
approved these changes
May 7, 2026
p-sawicki
reviewed
May 7, 2026
| are immutable, some race conditions that lists can be susceptible to are not possible | ||
| with vecs. | ||
|
|
||
| Implementation details |
Collaborator
There was a problem hiding this comment.
maybe mention some of the potential surprises related to sharing the same buffer among multiple vecs?
like an example where after creating an alias of a vec object, modifying either the original or the alias initially affects both, but that's not guaranteed to continue because one of the vecs might reallocate its buffer.
Collaborator
Author
There was a problem hiding this comment.
Added a discussion of this with some examples.
p-sawicki
approved these changes
May 7, 2026
Co-authored-by: Piotr Sawicki <sawickipiotr@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.