adjust pure_python check for option that PyPy might have _pickle#461
Open
mattip wants to merge 1 commit intopython:mainfrom
Open
adjust pure_python check for option that PyPy might have _pickle#461mattip wants to merge 1 commit intopython:mainfrom
mattip wants to merge 1 commit intopython:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am working on adding a _pickle RPython implementation to PyPy. I ran into a problem where the current benchmark will ignore that possibility and will always use the pure-python version on PyPy. This PR makes the logic work for the case that PyPy does have a _pickle module and, like CPython, it is activated by default, but retains backward compatibility.