Skip to content

Update sentinel#757

Open
zedzhen wants to merge 10 commits into
python:mainfrom
zedzhen:patch-1
Open

Update sentinel#757
zedzhen wants to merge 10 commits into
python:mainfrom
zedzhen:patch-1

Conversation

@zedzhen
Copy link
Copy Markdown

@zedzhen zedzhen commented May 19, 2026

@python-cla-bot
Copy link
Copy Markdown

python-cla-bot Bot commented May 19, 2026

All commit authors signed the Contributor License Agreement.

CLA signed

@HexDecimal
Copy link
Copy Markdown
Contributor

I assume the repr keyword should be added to the sentinel docs at doc/index.rst, and the versionchanged directive should be updated to clarify that only positional repr is deprecated.

@HexDecimal
Copy link
Copy Markdown
Contributor

HexDecimal commented May 19, 2026

The typing.Optional[str] parameter not acknowledging None is invalid and also breaks backwards compatibility.

Comment thread src/typing_extensions.py Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented May 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.39%. Comparing base (72895d0) to head (93aade6).

@@           Coverage Diff           @@
##             main     #757   +/-   ##
=======================================
  Coverage   97.38%   97.39%           
=======================================
  Files           3        3           
  Lines        7773     7785   +12     
=======================================
+ Hits         7570     7582   +12     
  Misses        203      203           
Flag Coverage Δ
3.10 89.10% <100.00%> (+0.01%) ⬆️
3.10.4 89.10% <100.00%> (+0.01%) ⬆️
3.11 88.34% <100.00%> (+0.01%) ⬆️
3.11.0 87.59% <100.00%> (+0.01%) ⬆️
3.12 88.29% <100.00%> (+0.01%) ⬆️
3.12.0 88.28% <100.00%> (+0.01%) ⬆️
3.13 83.08% <100.00%> (+0.02%) ⬆️
3.13.0 83.80% <100.00%> (+0.02%) ⬆️
3.14 79.17% <100.00%> (+0.03%) ⬆️
3.9 89.81% <100.00%> (+0.01%) ⬆️
3.9.12 89.81% <100.00%> (+0.01%) ⬆️
pypy3.10 88.94% <100.00%> (+0.01%) ⬆️
pypy3.11 88.20% <100.00%> (+0.01%) ⬆️
pypy3.9 89.64% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/test_typing_extensions.py 98.41% <100.00%> (+<0.01%) ⬆️
src/typing_extensions.py 93.95% <100.00%> (+0.02%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/typing_extensions.py Outdated
Comment thread doc/index.rst
Comment thread src/test_typing_extensions.py Outdated
zedzhen and others added 4 commits May 19, 2026 20:03
@zedzhen zedzhen requested a review from JelleZijlstra May 20, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Adapt Sentinel implementation to accepted version of PEP 661

3 participants