Skip to content

Conversation

@Gasoonjia
Copy link
Contributor

@Gasoonjia Gasoonjia commented Jan 5, 2026

Stack from ghstack (oldest at bottom):

Add SlimTensor-based implementations of basic property getter AOTI shim functions:

  1. aoti_torch_get_data_ptr() - Returns pointer to tensor data
  2. aoti_torch_get_sizes() - Returns pointer to sizes array (SlimTensor stores int64_t directly)
  3. aoti_torch_get_strides() - Returns pointer to strides array (SlimTensor stores int64_t directly)
  4. aoti_torch_get_dtype() - Returns the scalar type as int32_t
  5. aoti_torch_get_dim() - Returns the number of dimensions

Key design:

  • Create a new common_shim_slim.h for working on new API while not impact the current pipeline. Will use common_shim_slim.{h/cpp} to replace current common_shim.{h/cpp} when everything has been set up.
  • Uses #ifdef CUDA_AVAILABLE conditional compilation to seperate the implementation between cuda backend and mps backend since SlimTensor hasn't have mps support yet. Will remove the branch once SlimTensor support mps.
  • Refactored to a header-only library so the caller's preprocessor flags determine which tensor type is used. This design supports both CUDA backend (SlimTensor) and MPS backend (ETensor) from a single library.

Differential Revision: D90126254

Add SlimTensor-based implementations of basic property getter AOTI shim functions:

1. `aoti_torch_get_data_ptr()` - Returns pointer to tensor data
2. `aoti_torch_get_sizes()` - Returns pointer to sizes array (SlimTensor stores int64_t directly)
3. `aoti_torch_get_strides()` - Returns pointer to strides array (SlimTensor stores int64_t directly)
4. `aoti_torch_get_dtype()` - Returns the scalar type as int32_t
5. `aoti_torch_get_dim()` - Returns the number of dimensions

Key design:
- Create a new common_shim_slim.h for working on new API while not impact the current pipeline. Will use common_shim_slim.{h/cpp} to replace current common_shim.{h/cpp} when everything has been set up.
- Uses `#ifdef CUDA_AVAILABLE` conditional compilation to seperate the implementation between cuda backend and mps backend since SlimTensor hasn't have mps support yet. Will remove the branch once SlimTensor support mps.
- Refactored to a header-only library so the caller's preprocessor flags determine which tensor type is used. This design supports both CUDA backend (SlimTensor) and MPS backend (ETensor) from a single library.

Differential Revision: [D90126254](https://our.internmc.facebook.com/intern/diff/D90126254/)

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 5, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16454

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Pending, 2 Unrelated Failures

As of commit 3d9e562 with merge base 99348ed (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jan 5, 2026
@github-actions
Copy link

github-actions bot commented Jan 5, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

…ters"

Add SlimTensor-based implementations of basic property getter AOTI shim functions:

1. `aoti_torch_get_data_ptr()` - Returns pointer to tensor data
2. `aoti_torch_get_sizes()` - Returns pointer to sizes array (SlimTensor stores int64_t directly)
3. `aoti_torch_get_strides()` - Returns pointer to strides array (SlimTensor stores int64_t directly)
4. `aoti_torch_get_dtype()` - Returns the scalar type as int32_t
5. `aoti_torch_get_dim()` - Returns the number of dimensions

Key design:
- Create a new common_shim_slim.h for working on new API while not impact the current pipeline. Will use common_shim_slim.{h/cpp} to replace current common_shim.{h/cpp} when everything has been set up.
- Uses `#ifdef CUDA_AVAILABLE` conditional compilation to seperate the implementation between cuda backend and mps backend since SlimTensor hasn't have mps support yet. Will remove the branch once SlimTensor support mps.
- Refactored to a header-only library so the caller's preprocessor flags determine which tensor type is used. This design supports both CUDA backend (SlimTensor) and MPS backend (ETensor) from a single library.

Differential Revision: [D90126254](https://our.internmc.facebook.com/intern/diff/D90126254/)

[ghstack-poisoned]
…ters"

Add SlimTensor-based implementations of basic property getter AOTI shim functions:

1. `aoti_torch_get_data_ptr()` - Returns pointer to tensor data
2. `aoti_torch_get_sizes()` - Returns pointer to sizes array (SlimTensor stores int64_t directly)
3. `aoti_torch_get_strides()` - Returns pointer to strides array (SlimTensor stores int64_t directly)
4. `aoti_torch_get_dtype()` - Returns the scalar type as int32_t
5. `aoti_torch_get_dim()` - Returns the number of dimensions

Key design:
- Create a new common_shim_slim.h for working on new API while not impact the current pipeline. Will use common_shim_slim.{h/cpp} to replace current common_shim.{h/cpp} when everything has been set up.
- Uses `#ifdef CUDA_AVAILABLE` conditional compilation to seperate the implementation between cuda backend and mps backend since SlimTensor hasn't have mps support yet. Will remove the branch once SlimTensor support mps.
- Refactored to a header-only library so the caller's preprocessor flags determine which tensor type is used. This design supports both CUDA backend (SlimTensor) and MPS backend (ETensor) from a single library.

Differential Revision: [D90126254](https://our.internmc.facebook.com/intern/diff/D90126254/)

[ghstack-poisoned]
…ters"

Add SlimTensor-based implementations of basic property getter AOTI shim functions:

1. `aoti_torch_get_data_ptr()` - Returns pointer to tensor data
2. `aoti_torch_get_sizes()` - Returns pointer to sizes array (SlimTensor stores int64_t directly)
3. `aoti_torch_get_strides()` - Returns pointer to strides array (SlimTensor stores int64_t directly)
4. `aoti_torch_get_dtype()` - Returns the scalar type as int32_t
5. `aoti_torch_get_dim()` - Returns the number of dimensions

Key design:
- Create a new common_shim_slim.h for working on new API while not impact the current pipeline. Will use common_shim_slim.{h/cpp} to replace current common_shim.{h/cpp} when everything has been set up.
- Uses `#ifdef CUDA_AVAILABLE` conditional compilation to seperate the implementation between cuda backend and mps backend since SlimTensor hasn't have mps support yet. Will remove the branch once SlimTensor support mps.
- Refactored to a header-only library so the caller's preprocessor flags determine which tensor type is used. This design supports both CUDA backend (SlimTensor) and MPS backend (ETensor) from a single library.

Differential Revision: [D90126254](https://our.internmc.facebook.com/intern/diff/D90126254/)

[ghstack-poisoned]
…ters"

Add SlimTensor-based implementations of basic property getter AOTI shim functions:

1. `aoti_torch_get_data_ptr()` - Returns pointer to tensor data
2. `aoti_torch_get_sizes()` - Returns pointer to sizes array (SlimTensor stores int64_t directly)
3. `aoti_torch_get_strides()` - Returns pointer to strides array (SlimTensor stores int64_t directly)
4. `aoti_torch_get_dtype()` - Returns the scalar type as int32_t
5. `aoti_torch_get_dim()` - Returns the number of dimensions

Key design:
- Create a new common_shim_slim.h for working on new API while not impact the current pipeline. Will use common_shim_slim.{h/cpp} to replace current common_shim.{h/cpp} when everything has been set up.
- Uses `#ifdef CUDA_AVAILABLE` conditional compilation to seperate the implementation between cuda backend and mps backend since SlimTensor hasn't have mps support yet. Will remove the branch once SlimTensor support mps.
- Refactored to a header-only library so the caller's preprocessor flags determine which tensor type is used. This design supports both CUDA backend (SlimTensor) and MPS backend (ETensor) from a single library.

Differential Revision: [D90126254](https://our.internmc.facebook.com/intern/diff/D90126254/)

[ghstack-poisoned]
…ters"

Add SlimTensor-based implementations of basic property getter AOTI shim functions:

1. `aoti_torch_get_data_ptr()` - Returns pointer to tensor data
2. `aoti_torch_get_sizes()` - Returns pointer to sizes array (SlimTensor stores int64_t directly)
3. `aoti_torch_get_strides()` - Returns pointer to strides array (SlimTensor stores int64_t directly)
4. `aoti_torch_get_dtype()` - Returns the scalar type as int32_t
5. `aoti_torch_get_dim()` - Returns the number of dimensions

Key design:
- Create a new common_shim_slim.h for working on new API while not impact the current pipeline. Will use common_shim_slim.{h/cpp} to replace current common_shim.{h/cpp} when everything has been set up.
- Uses `#ifdef CUDA_AVAILABLE` conditional compilation to seperate the implementation between cuda backend and mps backend since SlimTensor hasn't have mps support yet. Will remove the branch once SlimTensor support mps.
- Refactored to a header-only library so the caller's preprocessor flags determine which tensor type is used. This design supports both CUDA backend (SlimTensor) and MPS backend (ETensor) from a single library.

Differential Revision: [D90126254](https://our.internmc.facebook.com/intern/diff/D90126254/)

[ghstack-poisoned]
…ters"

Add SlimTensor-based implementations of basic property getter AOTI shim functions:

1. `aoti_torch_get_data_ptr()` - Returns pointer to tensor data
2. `aoti_torch_get_sizes()` - Returns pointer to sizes array (SlimTensor stores int64_t directly)
3. `aoti_torch_get_strides()` - Returns pointer to strides array (SlimTensor stores int64_t directly)
4. `aoti_torch_get_dtype()` - Returns the scalar type as int32_t
5. `aoti_torch_get_dim()` - Returns the number of dimensions

Key design:
- Create a new common_shim_slim.h for working on new API while not impact the current pipeline. Will use common_shim_slim.{h/cpp} to replace current common_shim.{h/cpp} when everything has been set up.
- Uses `#ifdef CUDA_AVAILABLE` conditional compilation to seperate the implementation between cuda backend and mps backend since SlimTensor hasn't have mps support yet. Will remove the branch once SlimTensor support mps.
- Refactored to a header-only library so the caller's preprocessor flags determine which tensor type is used. This design supports both CUDA backend (SlimTensor) and MPS backend (ETensor) from a single library.

Differential Revision: [D90126254](https://our.internmc.facebook.com/intern/diff/D90126254/)

[ghstack-poisoned]
…ters"

Add SlimTensor-based implementations of basic property getter AOTI shim functions:

1. `aoti_torch_get_data_ptr()` - Returns pointer to tensor data
2. `aoti_torch_get_sizes()` - Returns pointer to sizes array (SlimTensor stores int64_t directly)
3. `aoti_torch_get_strides()` - Returns pointer to strides array (SlimTensor stores int64_t directly)
4. `aoti_torch_get_dtype()` - Returns the scalar type as int32_t
5. `aoti_torch_get_dim()` - Returns the number of dimensions

Key design:
- Create a new common_shim_slim.h for working on new API while not impact the current pipeline. Will use common_shim_slim.{h/cpp} to replace current common_shim.{h/cpp} when everything has been set up.
- Uses `#ifdef CUDA_AVAILABLE` conditional compilation to seperate the implementation between cuda backend and mps backend since SlimTensor hasn't have mps support yet. Will remove the branch once SlimTensor support mps.
- Refactored to a header-only library so the caller's preprocessor flags determine which tensor type is used. This design supports both CUDA backend (SlimTensor) and MPS backend (ETensor) from a single library.

Differential Revision: [D90126254](https://our.internmc.facebook.com/intern/diff/D90126254/)

[ghstack-poisoned]
…ters"

Add SlimTensor-based implementations of basic property getter AOTI shim functions:

1. `aoti_torch_get_data_ptr()` - Returns pointer to tensor data
2. `aoti_torch_get_sizes()` - Returns pointer to sizes array (SlimTensor stores int64_t directly)
3. `aoti_torch_get_strides()` - Returns pointer to strides array (SlimTensor stores int64_t directly)
4. `aoti_torch_get_dtype()` - Returns the scalar type as int32_t
5. `aoti_torch_get_dim()` - Returns the number of dimensions

Key design:
- Create a new common_shim_slim.h for working on new API while not impact the current pipeline. Will use common_shim_slim.{h/cpp} to replace current common_shim.{h/cpp} when everything has been set up.
- Uses `#ifdef CUDA_AVAILABLE` conditional compilation to seperate the implementation between cuda backend and mps backend since SlimTensor hasn't have mps support yet. Will remove the branch once SlimTensor support mps.
- Refactored to a header-only library so the caller's preprocessor flags determine which tensor type is used. This design supports both CUDA backend (SlimTensor) and MPS backend (ETensor) from a single library.

Differential Revision: [D90126254](https://our.internmc.facebook.com/intern/diff/D90126254/)

[ghstack-poisoned]
Gasoonjia added a commit that referenced this pull request Jan 27, 2026
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #16565
* #16551
* #16469
* #16457
* #16455
* #16454
* #16453
* #16452
* #16451
* #16450
* #16449
* #16448
* #16447
* #16446
* __->__ #16724

Copy CUDAGuard and CUDAStreamGuard from cuda/runtime/ to aoti/slim/cuda/
to support slimtensor requirement while get rid of potential circular
dependency:
- cuda_backend/main_functionalities -> aoti/slimtensor ->
cuda_backend/cuda_guard

This change:
- copy guard.h, guard.cpp and test files from backend/cuda_backend to
backend/aoti/slim/cuda/

Differential Revision:
[D91056808](https://our.internmc.facebook.com/intern/diff/D91056808/)
Gasoonjia added a commit that referenced this pull request Jan 27, 2026
…v2 (#16446)

Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #16565
* #16551
* #16469
* #16457
* #16455
* #16454
* #16453
* #16452
* #16451
* #16450
* #16449
* #16448
* #16447
* __->__ #16446
* #16724

Add SlimTensor-based implementations of AOTI shim functions for tensor
creation:

1. `aoti_torch_create_tensor_from_blob_v2()` - Creates a non-owning
SlimTensor that wraps existing memory using the `from_blob()` factory

Both functions support CPU and CUDA devices and handle all 7 SlimTensor
dtypes.

Also add `memory_slim.h` and `memory_slim.cpp` with SlimTensor-based
shim implementations for working on new API while not impact the current
pipeline. Will use memory_slim.{h/cpp} to replace current memory.{h/cpp}
when everything has been set up.

Differential Revision:
[D90126247](https://our.internmc.facebook.com/intern/diff/D90126247/)
Gasoonjia added a commit that referenced this pull request Jan 27, 2026
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at
bottom):
* #16565
* #16551
* #16469
* #16457
* #16455
* #16454
* #16453
* #16452
* #16451
* #16450
* #16449
* #16448
* __->__ #16447
* #16446
* #16724

Add SlimTensor-based implementations of AOTI shim functions for tensor
creation:

`aoti_torch_create_tensor_from_blob_v2()` - Creates a non-owning
SlimTensor that wraps existing memory using the `from_blob()` factory

Both functions support CPU and CUDA devices and handle all 7 SlimTensor
dtypes.

Changes:
- Add `memory_slim.h` and `memory_slim.cpp` with SlimTensor-based shim
implementations
- Add `runtime_shims_slim` library target to TARGETS with
`CUDA_AVAILABLE=1` preprocessor flag
- Add `cuda_shim_slim_cpp_unittest()` function for SlimTensor test
targets

Differential Revision:
[D90126244](https://our.internmc.facebook.com/intern/diff/D90126244/)
…ters"

Add SlimTensor-based implementations of basic property getter AOTI shim functions:

1. `aoti_torch_get_data_ptr()` - Returns pointer to tensor data
2. `aoti_torch_get_sizes()` - Returns pointer to sizes array (SlimTensor stores int64_t directly)
3. `aoti_torch_get_strides()` - Returns pointer to strides array (SlimTensor stores int64_t directly)
4. `aoti_torch_get_dtype()` - Returns the scalar type as int32_t
5. `aoti_torch_get_dim()` - Returns the number of dimensions

Key design:
- Create a new common_shim_slim.h for working on new API while not impact the current pipeline. Will use common_shim_slim.{h/cpp} to replace current common_shim.{h/cpp} when everything has been set up.
- Uses `#ifdef CUDA_AVAILABLE` conditional compilation to seperate the implementation between cuda backend and mps backend since SlimTensor hasn't have mps support yet. Will remove the branch once SlimTensor support mps.
- Refactored to a header-only library so the caller's preprocessor flags determine which tensor type is used. This design supports both CUDA backend (SlimTensor) and MPS backend (ETensor) from a single library.

Differential Revision: [D90126254](https://our.internmc.facebook.com/intern/diff/D90126254/)

[ghstack-poisoned]
…ters"

Add SlimTensor-based implementations of basic property getter AOTI shim functions:

1. `aoti_torch_get_data_ptr()` - Returns pointer to tensor data
2. `aoti_torch_get_sizes()` - Returns pointer to sizes array (SlimTensor stores int64_t directly)
3. `aoti_torch_get_strides()` - Returns pointer to strides array (SlimTensor stores int64_t directly)
4. `aoti_torch_get_dtype()` - Returns the scalar type as int32_t
5. `aoti_torch_get_dim()` - Returns the number of dimensions

Key design:
- Create a new common_shim_slim.h for working on new API while not impact the current pipeline. Will use common_shim_slim.{h/cpp} to replace current common_shim.{h/cpp} when everything has been set up.
- Uses `#ifdef CUDA_AVAILABLE` conditional compilation to seperate the implementation between cuda backend and mps backend since SlimTensor hasn't have mps support yet. Will remove the branch once SlimTensor support mps.
- Refactored to a header-only library so the caller's preprocessor flags determine which tensor type is used. This design supports both CUDA backend (SlimTensor) and MPS backend (ETensor) from a single library.

Differential Revision: [D90126254](https://our.internmc.facebook.com/intern/diff/D90126254/)

[ghstack-poisoned]
…ters"

Add SlimTensor-based implementations of basic property getter AOTI shim functions:

1. `aoti_torch_get_data_ptr()` - Returns pointer to tensor data
2. `aoti_torch_get_sizes()` - Returns pointer to sizes array (SlimTensor stores int64_t directly)
3. `aoti_torch_get_strides()` - Returns pointer to strides array (SlimTensor stores int64_t directly)
4. `aoti_torch_get_dtype()` - Returns the scalar type as int32_t
5. `aoti_torch_get_dim()` - Returns the number of dimensions

Key design:
- Create a new common_shim_slim.h for working on new API while not impact the current pipeline. Will use common_shim_slim.{h/cpp} to replace current common_shim.{h/cpp} when everything has been set up.
- Uses `#ifdef CUDA_AVAILABLE` conditional compilation to seperate the implementation between cuda backend and mps backend since SlimTensor hasn't have mps support yet. Will remove the branch once SlimTensor support mps.
- Refactored to a header-only library so the caller's preprocessor flags determine which tensor type is used. This design supports both CUDA backend (SlimTensor) and MPS backend (ETensor) from a single library.

Differential Revision: [D90126254](https://our.internmc.facebook.com/intern/diff/D90126254/)

[ghstack-poisoned]
@meta-codesync meta-codesync bot merged commit b0201ac into gh/gasoonjia/96/base Jan 29, 2026
258 of 265 checks passed
@meta-codesync meta-codesync bot deleted the gh/gasoonjia/96/head branch January 29, 2026 01:14
Gasoonjia added a commit that referenced this pull request Jan 29, 2026
This PR was created by the merge bot to help merge the original PR into
the main branch.
ghstack PR number: #16454 by
@Gasoonjia
^ Please use this as the source of truth for the PR details, comments,
and reviews
ghstack PR base:
https://github.com/pytorch/executorch/tree/gh/gasoonjia/96/base
ghstack PR head:
https://github.com/pytorch/executorch/tree/gh/gasoonjia/96/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head:
https://github.com/pytorch/executorch/tree/gh/gasoonjia/96/orig
Differential Revision:
[D90126254](https://our.internmc.facebook.com/intern/diff/D90126254/)
@diff-train-skip-merge

Co-authored-by: gasoonjia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants