Skip to content

Conversation

@perheld
Copy link
Collaborator

@perheld perheld commented Jan 23, 2026

Add tooling for bandit to run with lintrunner.

Signed-off-by: per.held@arm.com
Change-Id: I76f6f9336e161ed04b7c062b0b437a23ba497f09

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

@perheld perheld added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Jan 23, 2026
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 23, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16827

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Pending

As of commit 6f2cad2 with merge base e9a1937 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 23, 2026
@zingo
Copy link
Collaborator

zingo commented Jan 23, 2026

Hi @SS-JIA this enable more lintrunning stuff for Arm folder but as it's in the global config files I assume we need a proper review :)

Copy link
Contributor

@SS-JIA SS-JIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be ok since there are no changes to existing linters. Test failures do seem unrelated to me, but would be good to double check

certifi # Imported by resolve_buck.py.
lintrunner==0.12.7
lintrunner-adapters==0.12.6
lintrunner-adapters==0.13.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change is notable but should be okay as long as lintrunner passes

Copy link
Collaborator Author

@perheld perheld Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it needs to be bumped to have support for bandit. I created the PR with support and got it merged so they where kind enough to make a new release. :)
justinchuby/lintrunner-adapters#132

@zingo
Copy link
Collaborator

zingo commented Jan 23, 2026

Just merged a fix for some Arm-backend tests rebasing to clean out those errors :)

Add tooling for bandit to run with lintrunner.

Signed-off-by: per.held@arm.com
Change-Id: I76f6f9336e161ed04b7c062b0b437a23ba497f09
@perheld
Copy link
Collaborator Author

perheld commented Jan 27, 2026

Cortex-m seems unrelated. Lintrunner job ran so Im quite confident this should work.

@perheld perheld merged commit 7770407 into pytorch:main Jan 27, 2026
310 of 311 checks passed
@perheld perheld deleted the ph-bandit branch January 27, 2026 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants