-
Notifications
You must be signed in to change notification settings - Fork 814
Arm backend: Fix replace_inf pass test names #16828
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pre-push naming checks require test_PASS_TARGET_* in passes. Rename the replace_inf tests to use the pass token (replace_inf_and_limit_values) and add a target suffix so the hook accepts them. Signed-off-by: Martin Lindström <Martin.Lindstroem@arm.com> Change-Id: I69c9d521977e4f89b0b154c731f4f72f6577e0ce
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16828
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit c87f46c with merge base ac0a201 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@pytorchbot label ciflow/trunk |
|
@pytorchbot label "partner: arm" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates Arm backend pass test naming to satisfy the repository’s pre-push naming convention checks for tests under backends/arm/test/passes.
Changes:
- Renamed
replace_infpass tests to use the correct pass token:replace_inf_and_limit_values. - Added an explicit target token (
no_target) to the renamed tests so they matchtest_PASS_TARGET_*.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
|
|
||
| def test_replace_inf_values_pass_clamps_inf_constants(): | ||
| def test_replace_inf_and_limit_values_no_target_clamps_inf_constants(): |
Copilot
AI
Jan 23, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test function names were updated to use the pass token replace_inf_and_limit_values, but the module filename is still test_replace_inf_values_pass.py. In this directory, pass tests are typically named after the pass token (e.g., test_decompose_avg_pool2d_pass.py, test_promote_bool_operands_pass.py), so keeping the old filename makes it harder to find/grep the tests for ReplaceInfAndLimitValuesPass. Consider renaming the file to match the pass (and updating any references if present).
zingo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK to merge when you can get the Arm Backend tests to PASS
I spot
FAILED backends/arm/test/ops/test_sub.py::test_sub_tensor_tosa_INT_2[rand_3d_Scalar] - AssertionError: Output 0 does not match reference output.
So you might just need to re-run the failed tests.
|
@pytorchbot label "release notes: none" |
Pre-push naming checks require test_PASS_TARGET_* in passes. Rename the replace_inf tests to use the pass token (replace_inf_and_limit_values) and add a target suffix so the hook accepts them.
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai