Skip to content

Conversation

@martinlsm
Copy link
Collaborator

@martinlsm martinlsm commented Jan 23, 2026

Pre-push naming checks require test_PASS_TARGET_* in passes. Rename the replace_inf tests to use the pass token (replace_inf_and_limit_values) and add a target suffix so the hook accepts them.

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

Pre-push naming checks require test_PASS_TARGET_* in passes. Rename the
replace_inf tests to use the pass token (replace_inf_and_limit_values)
and add a target suffix so the hook accepts them.

Signed-off-by: Martin Lindström <Martin.Lindstroem@arm.com>
Change-Id: I69c9d521977e4f89b0b154c731f4f72f6577e0ce
Copilot AI review requested due to automatic review settings January 23, 2026 13:56
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 23, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16828

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit c87f46c with merge base ac0a201 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 23, 2026
@martinlsm
Copy link
Collaborator Author

@pytorchbot label ciflow/trunk

@martinlsm
Copy link
Collaborator Author

@pytorchbot label "partner: arm"

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Jan 23, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Arm backend pass test naming to satisfy the repository’s pre-push naming convention checks for tests under backends/arm/test/passes.

Changes:

  • Renamed replace_inf pass tests to use the correct pass token: replace_inf_and_limit_values.
  • Added an explicit target token (no_target) to the renamed tests so they match test_PASS_TARGET_*.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.



def test_replace_inf_values_pass_clamps_inf_constants():
def test_replace_inf_and_limit_values_no_target_clamps_inf_constants():
Copy link

Copilot AI Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test function names were updated to use the pass token replace_inf_and_limit_values, but the module filename is still test_replace_inf_values_pass.py. In this directory, pass tests are typically named after the pass token (e.g., test_decompose_avg_pool2d_pass.py, test_promote_bool_operands_pass.py), so keeping the old filename makes it harder to find/grep the tests for ReplaceInfAndLimitValuesPass. Consider renaming the file to match the pass (and updating any references if present).

Copilot uses AI. Check for mistakes.
Copy link
Collaborator

@zingo zingo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to merge when you can get the Arm Backend tests to PASS

I spot

FAILED backends/arm/test/ops/test_sub.py::test_sub_tensor_tosa_INT_2[rand_3d_Scalar] - AssertionError: Output 0 does not match reference output.

So you might just need to re-run the failed tests.

@martinlsm
Copy link
Collaborator Author

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label Jan 26, 2026
@martinlsm martinlsm merged commit da56b4c into pytorch:main Jan 27, 2026
388 of 393 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants