Qualcomm arange #16833
Qualcomm arange #16833
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16833
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 1 Unrelated FailureAs of commit dbf00c4 with merge base b928496 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
JacobSzwejbka
force-pushed
the
qualcomm-arange
branch
from
59b74e5 to
73bfc7d
Compare
This PR needs a
|
|
@haowhsu-quic @winskuo-quic @shewu-quic @DannyYuyang-quic any chance you know a good way to handle this patch? |
|
@JacobSzwejbka has imported this pull request. If you are a Meta employee, you can view this in D91345139. |
shewu-quic
left a comment
shewu-quic
left a comment
There was a problem hiding this comment.
Thanks for fixing it.
| start, end = node.args[0:2] | ||
| step = node.args[2] if len(node.args) > 2 else 1 | ||
| out_tensor = torch.arange(start, end, step) | ||
| dtype = node.kwargs.get("dtype") |
There was a problem hiding this comment.
How about use node.meta["val"].dtype? I think it will not be None.
| f"Output {i} mismatch: got {out}, expected {ref}", | ||
| ) | ||
|
|
||
| def test_arange_dtype_from_kwargs(self): |
There was a problem hiding this comment.
Could you reuse original unit test for arange op?
Such as add more dtype coverage.
No description provided.