-
Notifications
You must be signed in to change notification settings - Fork 814
Update Android artifact naming and version to 1.2.0-SNAPSHOT #16846
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Android artifact naming and version to 1.2.0-SNAPSHOT #16846
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16846
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 2 Unrelated FailuresAs of commit d8251f8 with merge base 2d6c2ef ( NEW FAILURES - The following jobs have failed:
FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
…0-SNAPSHOT Co-authored-by: kirklandsign <107070759+kirklandsign@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the Android artifact naming convention to treat xnnpack as the default flavor (producing executorch-android without suffix) and updates the default version to 1.2.0-SNAPSHOT. This change aligns the main branch with the artifact naming modifications from PR #16806.
Changes:
- Modified artifact naming logic to exclude the
-xnnpacksuffix, making it the default flavor - Updated default version from
1.0.0-SNAPSHOTto1.2.0-SNAPSHOT
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Summary
Applies artifact naming change from #16806 to main branch: treats
xnnpackas the default flavor, producingexecutorch-androidwithout suffix. Other flavors (e.g.,qnn) retain the-<flavor>suffix. Updates default version to1.2.0-SNAPSHOT.Before:
After:
Test plan
Changes are to Gradle configuration only. Artifact naming will be validated through Maven Central publishing workflow.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.