Skip to content

Allow building aarch64|arm64 (Large VM, Debian) for a rpi4 deployment #16860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
NickJLange wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Allow building aarch64|arm64 (Large VM, Debian) for a rpi4 deployment #16860

NickJLange wants to merge 3 commits into from
+4 −1

Conversation

@NickJLange
Copy link

@NickJLange NickJLange commented Jan 25, 2026 •
edited
Loading

Summary

I'm not sure why the current build script has the current logic, but to compile on an aarch64|arm64 VM for deployment to a rpi4, we need to use the right cross-compiler. This fixes the selection. Hopefully in dialogue the original logic will emerge.
Test plan

Built on a Debian Bookworm VM (Large) for deployment to a Debian RPI4 (Small)

Per request, fixed the arm64 logic as well.

The original PR (#16734) would not refresh, so I've closed and re-opened. Apologies for the noise @kirklandsign !

Copilot AI review requested due to automatic review settings January 25, 2026 07:50
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 25, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16860

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 3fe3c93 with merge base 15ad846 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 25, 2026
@github-actions
Copy link

github-actions bot commented Jan 25, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot AI reviewed Jan 25, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the Raspberry Pi cross-compilation setup script to correctly detect arm64/aarch64 hosts so the proper ARM GNU toolchain is selected when building on ARM64 VMs for Raspberry Pi deployment.

Changes:

  • Updates host-architecture normalization to map arm64/aarch64 to aarch64 (instead of x86_64).
  • Keeps x86_64/amd64 normalization unchanged.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@NickJLange @ampcode-com
Allow building aarch64|arm64 (Large VM, Debian) for a rpi4 deployment
f5ddd45 
I'm not sure why the current build script has the current logic, but
to compile on an aarch64 VM for deployment to a rpi4, we need to use
the right cross-compiler.

Per request, also fixing the arm64 logic.

NB: I've rebased this against main, not v1.0.0 as I think this is a generic fix that can be backported if needed
Amp-Thread-ID: https://ampcode.com/threads/T-019bf424-c136-70b1-80a5-99c96af65642
Co-authored-by: Amp <amp@ampcode.com>
@NickJLange NickJLange force-pushed the fix/aarch64_build_for_aarch64 branch from 37541a5 to f5ddd45 Compare January 25, 2026 07:53
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 25, 2026

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'label:' (choose from 'merge', 'revert', 'rebase', 'label', 'drci', 'cherry-pick')

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick} ...

Try @pytorchbot --help for more info.

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 25, 2026

Didn't find following labels among repository labels: release notes: bug

@NickJLange NickJLange requested a review from Copilot January 25, 2026 07:56
Copilot AI reviewed Jan 25, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 27, 2026 03:29
Copilot AI reviewed Jan 27, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@kirklandsign kirklandsign kirklandsign approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NickJLange @kirklandsign