Skip to content

Conversation

@zingo
Copy link
Collaborator

@zingo zingo commented Jan 26, 2026

Summary

Split ZephyrOS tests per target so tests can run separate if wanted
and add support to run multipe tests after setup if you want to run
them all localy.

This removed the allowpattern as it would not stop bad code anyway
but gives the false impression that it does, removing the check also
make the code more easy to understant.

This also introduces invisible tags in the README.md in the form of

To make the parsing a bit more machine friendly and to make it easier
to change the readable text without strange test side effects.

This also only set git user in CI scripts if not already set and backup test folder so you don't destroy existing work or test data. This allows the script to be run locally more easy for testing.

Test plan

Test is part of this PR

zingo added 2 commits January 26, 2026 11:24
Change-Id: I4fd4fb9c2c3aeb7e620a1c17dd4ebfb1bf184231
Signed-off-by: Zingo Andersen <Zingo.Andersen@arm.com>
Also backup test folder so you don't destroy existing work or test data.
This allows the script to be run localy more easy for testing.

Signed-off-by: Zingo Andersen <Zingo.Andersen@arm.com>
Change-Id: Ib8fe19262891764fee8595ddd4982116585e4e5e
@zingo zingo requested a review from digantdesai as a code owner January 26, 2026 10:35
@zingo zingo added ciflow/trunk module: arm Issues related to arm backend release notes: none Do not include this in the release notes labels Jan 26, 2026
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 26, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16868

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit c5238d3 with merge base 4ef9b51 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 26, 2026
Split ZephyrOS tests per target so tests can run separate if wanted
and add support to run multipe tests after setup if you want to run
them all localy.

This removed the allowpattern as it would not stop bad code anyway
but gives the false impression that it does, removing the check also
make the code more easy to understant.

This also introduces invisible tags in the README.md in the form of
<!-- RUN TAGNAME -->
To make the parsing a bit more machine friendly and to make it easier
to change the readable text without strange test side effects.

Signed-off-by: Zingo Andersen <Zingo.Andersen@arm.com>
Change-Id: I69285db4c7d99febd53becaedc5afa83321731fc
@zingo zingo force-pushed the Arm-backend-Split-ZephyrOS-tests-per-target-and-add-SDK-to-docker branch from 905f85b to dcf6e76 Compare January 27, 2026 06:09
@zingo
Copy link
Collaborator Author

zingo commented Jan 27, 2026

Cortex-M fails: test_implementation_activation (12 fails) and test_implementation_linners (1 fail) are also failing on main.

@zingo
Copy link
Collaborator Author

zingo commented Jan 27, 2026

Hi @SS-JIA or @rascani anything you want to check/look at with this ZephyrOS tests update before merging?

@rascani
Copy link
Contributor

rascani commented Jan 27, 2026

Hi @SS-JIA or @rascani anything you want to check/look at with this ZephyrOS tests update before merging?

This looks good to me. Thank you for setting this up!

@zingo zingo merged commit 5690d26 into pytorch:main Jan 27, 2026
452 of 455 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants