Skip to content

Conversation

@mergennachin
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings January 26, 2026 18:16
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 26, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16875

Note: Links to docs will display an error until the docs builds have been completed.

❌ 12 New Failures, 7 Cancelled Jobs, 1 Unrelated Failure

As of commit c6acd95 with merge base ecc7dd0 (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOBS - The following jobs were cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 26, 2026
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@mergennachin mergennachin marked this pull request as draft January 26, 2026 18:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the transformers library dependency from version 5.0.0rc1 (release candidate) and 4.56.1 to >= 5.0.0 (stable release) across two requirements files. This change moves from pinned pre-release and older stable versions to a minimum version constraint allowing any transformers version 5.0.0 or later.

Changes:

  • Updated requirements-examples.txt from transformers == 5.0.0rc1 to transformers >= 5.0.0
  • Updated .ci/docker/requirements-ci.txt from transformers==4.56.1 to transformers>=5.0.0

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
requirements-examples.txt Updates transformers from RC version to stable >= 5.0.0 for example dependencies
.ci/docker/requirements-ci.txt Updates transformers from 4.56.1 to >= 5.0.0 for CI environment dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

torchsr == 1.0.4
torchtune >= 0.6.1
transformers == 5.0.0rc1
transformers >= 5.0.0
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update to transformers >= 5.0.0 conflicts with documentation that explicitly states support for transformers v4.56.1. The file examples/models/phi-3-mini/README.md (line 7) states "Currently, we support transformers v4.56.1" and provides installation instructions for that specific version. This documentation needs to be updated to reflect the new version requirement, or the compatibility should be verified and documented.

Suggested change
transformers >= 5.0.0
transformers == 4.56.1

Copilot uses AI. Check for mistakes.
torchsr == 1.0.4
torchtune >= 0.6.1
transformers == 5.0.0rc1
transformers >= 5.0.0
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The update to transformers >= 5.0.0 appears incomplete. The file examples/arm/image_classification_example/requirements.txt still pins to transformers[torch] == 4.56.1. This version mismatch could cause inconsistencies between different examples. Consider updating examples/arm/image_classification_example/requirements.txt to align with this version requirement, or verify that the ARM example is compatible with transformers 5.0.0.

Suggested change
transformers >= 5.0.0
transformers[torch] == 4.56.1

Copilot uses AI. Check for mistakes.
tomli==2.0.1
torchsr==1.0.4
transformers==4.56.1
transformers>=5.0.0
Copy link

Copilot AI Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The transformers dependency in requirements-ci.txt is now specified as >=5.0.0, so CI will automatically install whatever future version of this third‑party package is published. If the transformers package or its distribution channel is ever compromised, a malicious release could be pulled into CI and execute arbitrary code with access to secrets or the ability to modify build artifacts. To reduce supply-chain risk, pin this dependency to a specific immutable version (or hash) and update it intentionally rather than via an open version range.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants