-
Notifications
You must be signed in to change notification settings - Fork 818
Reduce log noise #16879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce log noise #16879
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16879
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 4 Pending, 1 Unrelated FailureAs of commit b0f8c46 with merge base b729d35 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR reduces log noise by simplifying an error message that previously included potentially large binary buffer data. The change removes the actual buffer contents from the ValueError message when duplicate keys with different data are detected, keeping only the key identifier.
Changes:
- Simplified error message in NamedDataStore to exclude potentially large binary buffer data while retaining the duplicate key name
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5521430 to
b0f8c46
Compare
copy of #16877 ..