Skip to content

[RELEASE ONLY CHANGES] Remove trailing slash from TORCH_URL_BASE #16892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergennachin merged 1 commit into from
Jan 27, 2026
Merged

[RELEASE ONLY CHANGES] Remove trailing slash from TORCH_URL_BASE #16892

mergennachin merged 1 commit into from
Jan 27, 2026

Conversation

@rascani
Copy link
Contributor

@rascani rascani commented Jan 27, 2026

The trailing slash on TORCH_URL_BASE caused the install_requirements.py to pick up the torchvision from PyPI rather than the pytorch index url.

@rascani
[RELEASE ONLY CHANGES] Remove trailing slash from TORCH_URL_BASE
513ebc6 
The trailing slash on TORCH_URL_BASE caused the install_requirements.py
to pick up the torchvision from PyPI rather than the pytorch index url.
@rascani rascani requested a review from mergennachin January 27, 2026 01:55
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 27, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16892

Note: Links to docs will display an error until the docs builds have been completed.

❌ 32 New Failures, 1 Cancelled Job, 1 Pending

As of commit 513ebc6 with merge base 7492d0d (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 27, 2026
mergennachin
mergennachin approved these changes Jan 27, 2026
View reviewed changes
Copy link
Contributor

@mergennachin mergennachin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tentatively accepted

@mergennachin mergennachin merged commit 17adba1 into pytorch:release/1.1 Jan 27, 2026
146 of 184 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mergennachin mergennachin mergennachin approved these changes

Assignees

No one assigned

Labels

ciflow/binaries CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rascani @mergennachin