Skip to content

Conversation

@mvartani-meta
Copy link

Summary: This diff introduces a modified method for masking. Instead of using the mask tensor, the function uses a position tensor where it attends the values up to the position value. In addition, the current implementation only reads the first value from the position tensor and then increments by one for each additional row.

Differential Revision: D88997196

Summary: This diff introduces a modified method for masking. Instead of using the mask tensor, the function uses a position tensor where it attends the values up to the position value. In addition, the current implementation only reads the first value from the position tensor and then increments by one for each additional row.

Differential Revision: D88997196
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 27, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16907

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 3fbab11 with merge base 2e99d9e (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 27, 2026
@meta-codesync
Copy link
Contributor

meta-codesync bot commented Jan 27, 2026

@mvartani-meta has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88997196.

@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant