Rename build files from TARGETS to BUCK (group ID: 3485166160954859926)

[bigfootjon]

Reviewed By: bigfootjon

Differential Revision: D91591060

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16922

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit 302117c with merge base 914d5ff ():

NEW FAILURE - The following job has failed:

• Test CUDA Builds / test-model-cuda-e2e (mistralai, Voxtral-Mini-3B-2507, quantized-int4-tile-packed) / linux-job (gh)
  RuntimeError: Command docker exec -t 96ff4690a552347fd7d107583f383f7ba999ebe3a8e778e5a8296eb2a9717412 /exec failed with exit code 1

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

• Test Metal Backend / test-model-metal-e2e (openai, whisper-large-v3-turbo, non-quantized) / macos-job (gh) (trunk failure)
  RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
• Test Metal Backend / test-model-metal-e2e (openai, whisper-small, non-quantized) / macos-job (gh) (trunk failure)
  RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[meta-codesync]

@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91591060.

[github-actions]

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

[Copilot]

Pull request overview

Migrates build definitions from TARGETS to BUCK and starts using build-file migration macros to support fbcode vs non-fbcode target selection.

Changes:

• Removed backends/test/TARGETS and merged its content into backends/test/BUCK.
• Added fbcode_target / non_fbcode_target wrappers in select BUCK files.
• Updated Qualcomm backend BUCK files to use migration macro wrappers for target definitions.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
backends/test/TARGETS	Removed legacy TARGETS build file (content moved into BUCK).
backends/test/BUCK	Consolidates fbcode and non-fbcode build definitions into a single BUCK file using migration wrappers.
backends/qualcomm/utils/BUCK	Adds migration macro load and wraps target definition.
backends/qualcomm/tests/BUCK	Adds migration macro load and wraps python targets with migration macro wrapper.

Comments suppressed due to low confidence (2)

backends/qualcomm/utils/BUCK:1

• non_fbcode_target is loaded but never used in this file. Please remove it from the load() to avoid unused symbols (and keep loads consistent with other usage, e.g. extension/android/jni/selective_jni.buck.bzl:1 loads only what it uses).
  backends/qualcomm/tests/BUCK:4
• Several loaded symbols are unused: non_fbcode_target (added here) is never referenced, python_unittest is not used anywhere in this file, and get_qnn_library_version is only referenced in commented-out code. Please remove unused loads (or re-enable the code that uses them) to keep the BUCK file clean and avoid lint failures.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Minor formatting: add spaces after commas in the fbcode_target(...) call (e.g., between _kind and is_fbcode) to match typical BUCK/Starlark style and improve readability.

Suggested change

	fbcode_target(_kind = define_common_targets,is_fbcode = True)
	fbcode_target(_kind = define_common_targets, is_fbcode = True)

[Copilot]

load(":targets.bzl", "define_common_targets") is duplicated in the same file; the second load (and its surrounding duplicated header comment block) should be removed/merged to keep the build file DRY and avoid confusion during future edits.

Suggested change

	# targets.bzl. This file can contain fbcode-only targets.
	load(":targets.bzl", "define_common_targets")
	fbcode_target(_kind = define_common_targets,is_fbcode = True)
	# targets.bzl. This file can contain both xplat-only and fbcode-only targets.
	fbcode_target(_kind = define_common_targets,is_fbcode = True)