Skip to content

Rename build files from TARGETS to BUCK (group ID: 3485166160954859926) #16922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bigfootjon wants to merge 1 commit into from
+20 −15
Closed

Rename build files from TARGETS to BUCK (group ID: 3485166160954859926) #16922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions backends/qualcomm/tests/TARGETS → backends/qualcomm/tests/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,19 @@
load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target")
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
load("@fbcode_macros//build_defs:python_unittest.bzl", "python_unittest")
load("@fbsource//xplat/executorch/backends/qualcomm/qnn_version.bzl", "get_qnn_library_version")

oncall("executorch")

runtime.python_library(
fbcode_target(_kind = runtime.python_library,
name = "models",
srcs = ["models.py"],
deps = [
"//caffe2:torch",
]
)

runtime.python_library(
fbcode_target(_kind = runtime.python_library,
name = "test_qnn_delegate",
srcs = [
"test_qnn_delegate.py",
Expand Down Expand Up @@ -41,7 +42,7 @@ runtime.python_library(
],
)

runtime.python_library(
fbcode_target(_kind = runtime.python_library,
name = "tester",
srcs = [
"tester.py",
Expand All @@ -51,7 +52,7 @@ runtime.python_library(
]
)

runtime.python_test(
fbcode_target(_kind = runtime.python_test,
name = "test_passes",
srcs = [
"test_passes.py",
Expand Down
3 changes: 2 additions & 1 deletion backends/qualcomm/utils/TARGETS → backends/qualcomm/utils/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target")
# Any targets that should be shared between fbcode and xplat must be defined in
# targets.bzl. This file can contain fbcode-only targets.

load(":targets.bzl", "define_common_targets")

oncall("executorch")

define_common_targets()
fbcode_target(_kind = define_common_targets,)
15 changes: 13 additions & 2 deletions backends/test/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,19 @@
load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target")
oncall("executorch")
# Any targets that should be shared between fbcode and xplat must be defined in
# targets.bzl. This file can contain xplat-only targets.

load(":targets.bzl", "define_common_targets")

oncall("executorch")

define_common_targets()
non_fbcode_target(_kind = define_common_targets,)

# !!!! fbcode/executorch/backends/test/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!!

# Any targets that should be shared between fbcode and xplat must be defined in
# targets.bzl. This file can contain fbcode-only targets.

load(":targets.bzl", "define_common_targets")


fbcode_target(_kind = define_common_targets,is_fbcode = True)
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor formatting: add spaces after commas in the fbcode_target(...) call (e.g., between _kind and is_fbcode) to match typical BUCK/Starlark style and improve readability.

Suggested change
fbcode_target(_kind = define_common_targets,is_fbcode = True)
fbcode_target(_kind = define_common_targets, is_fbcode = True)

Copilot uses AI. Check for mistakes.
Comment on lines +14 to +19
Copy link

Copilot AI Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

load(":targets.bzl", "define_common_targets") is duplicated in the same file; the second load (and its surrounding duplicated header comment block) should be removed/merged to keep the build file DRY and avoid confusion during future edits.

Suggested change
# targets.bzl. This file can contain fbcode-only targets.
load(":targets.bzl", "define_common_targets")
fbcode_target(_kind = define_common_targets,is_fbcode = True)
# targets.bzl. This file can contain both xplat-only and fbcode-only targets.
fbcode_target(_kind = define_common_targets,is_fbcode = True)

Copilot uses AI. Check for mistakes.
8 changes: 0 additions & 8 deletions backends/test/TARGETS
View file
Open in desktop

This file was deleted.

Loading