Add dual-conv tests for add/sub dual-input ifm scaling (#18755)#18755

Open

3l1 wants to merge 2 commits intomainfrom

export-D99934624

Contributor

3l1 commented Apr 8, 2026 •

edited by meta-codesync bot

Loading

Summary:

Add AddDualConv and SubDualConv test models (conv1(x) +/- conv2(x)) where both inputs of the Add/Sub have Rescale producers.

Differential Revision: D99934624

3l1 requested a review from digantdesai as a code owner

April 8, 2026 01:29

pytorch-bot bot commented Apr 8, 2026 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18755

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Unrelated Failures

As of commit 5634b27 with merge base 21d9c64 ():

NEW FAILURES - The following jobs have failed:

pull / unittest / macos / macos-job (gh)
export/tests/test_target_recipes.py::TestTargetRecipes::test_mv3_model
pull / unittest-editable / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / unittest / windows / windows-job (gh) (trunk failure)
##[error]The operation was canceled.
pull / unittest-editable / windows / windows-job (gh) (trunk failure)
##[error]The operation was canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-cla bot added the CLA Signed label

Contributor

meta-codesync bot commented Apr 8, 2026

@3l1 has exported this pull request. If you are a Meta employee, you can view the originating Diff in D99934624.

meta-codesync bot added fb-exported meta-exported labels

github-actions bot commented Apr 8, 2026

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

meta-codesync bot force-pushed the export-D99934624 branch from c70498b to 97f8f11 Compare

April 8, 2026 01:32

meta-codesync bot changed the title ~~Add dual-conv tests for Add/Sub dual-input rescale fusion~~ Add dual-conv tests for add/sub dual-input rescale fusion (#18755)

meta-codesync bot pushed a commit that referenced this pull request


          Add dual-conv tests for add/sub dual-input rescale fusion (#18755)

862aae5

Summary:

Add AddDualConv and SubDualConv test models (conv1(x) +/- conv2(x)) where both inputs of the Add/Sub have Rescale producers.

Differential Revision: D99934624

meta-codesync bot force-pushed the export-D99934624 branch from 97f8f11 to 862aae5 Compare

April 8, 2026 01:33

3l1 changed the title ~~Add dual-conv tests for add/sub dual-input rescale fusion (#18755)~~ Add dual-conv tests for add/sub (#18755)

meta-codesync bot pushed a commit that referenced this pull request


          Add dual-conv tests for add/sub dual-input rescale fusion (#18755)

f8b8006

Summary:

Add AddDualConv and SubDualConv test models (conv1(x) +/- conv2(x)) where both inputs of the Add/Sub have Rescale producers.

Differential Revision: D99934624

meta-codesync bot changed the title ~~Add dual-conv tests for add/sub (#18755)~~ Add dual-conv tests for add/sub dual-input rescale fusion (#18755)

meta-codesync bot pushed a commit that referenced this pull request


          Add dual-conv tests for add/sub dual-input rescale fusion (#18755)

0e10a1c

Summary:

Add AddDualConv and SubDualConv test models (conv1(x) +/- conv2(x)) where both inputs of the Add/Sub have Rescale producers.

Differential Revision: D99934624

meta-codesync bot force-pushed the export-D99934624 branch from 862aae5 to 0e10a1c Compare

April 8, 2026 02:43

meta-codesync bot pushed a commit that referenced this pull request


          Add dual-conv tests for add/sub dual-input rescale fusion (#18755)

f518e16

Summary:

Add AddDualConv and SubDualConv test models (conv1(x) +/- conv2(x)) where both inputs of the Add/Sub have Rescale producers.

Differential Revision: D99934624

3l1 added a commit that referenced this pull request


          Add dual-conv tests for add/sub dual-input rescale fusion (#18755)

d4ffcf2

Summary:
Pull Request resolved: #18755

Add AddDualConv and SubDualConv test models (conv1(x) +/- conv2(x)) where both inputs of the Add/Sub have Rescale producers.

Differential Revision: D99934624

3l1 force-pushed the export-D99934624 branch from 0e10a1c to d4ffcf2 Compare

April 8, 2026 02:46

meta-codesync bot changed the title ~~Add dual-conv tests for add/sub dual-input rescale fusion (#18755)~~ Add dual-conv tests for add/sub dual-input ifm scaling (#18755)

meta-codesync bot pushed a commit that referenced this pull request


          Add dual-conv tests for add/sub dual-input ifm scaling (#18755)

ee4ab70

Summary:

Add AddDualConv and SubDualConv test models (conv1(x) +/- conv2(x)) where both inputs of the Add/Sub have Rescale producers.

Differential Revision: D99934624

meta-codesync bot force-pushed the export-D99934624 branch 2 times, most recently from ee4ab70 to 7d22ace Compare

April 8, 2026 04:55

meta-codesync bot pushed a commit that referenced this pull request


          Add dual-conv tests for add/sub dual-input ifm scaling (#18755)

7d22ace

Summary:

Add AddDualConv and SubDualConv test models (conv1(x) +/- conv2(x)) where both inputs of the Add/Sub have Rescale producers.

Differential Revision: D99934624

meta-codesync bot pushed a commit that referenced this pull request


          Add dual-conv tests for add/sub dual-input ifm scaling (#18755)

3df60d4

Summary:

Add AddDualConv and SubDualConv test models (conv1(x) +/- conv2(x)) where both inputs of the Add/Sub have Rescale producers.

Differential Revision: D99934624

3l1 added a commit that referenced this pull request


          Add dual-conv tests for add/sub dual-input ifm scaling (#18755)

0df440b

Summary:
Pull Request resolved: #18755

Add AddDualConv and SubDualConv test models (conv1(x) +/- conv2(x)) where both inputs of the Add/Sub have Rescale producers.

Differential Revision: D99934624

3l1 force-pushed the export-D99934624 branch from 7d22ace to 0df440b Compare

April 8, 2026 04:57

meta-codesync bot pushed a commit that referenced this pull request


          Add dual-conv tests for add/sub dual-input ifm scaling (#18755)

ea551bd

Summary:

Add AddDualConv and SubDualConv test models (conv1(x) +/- conv2(x)) where both inputs of the Add/Sub have Rescale producers.

Differential Revision: D99934624

meta-codesync bot force-pushed the export-D99934624 branch from 0df440b to ea551bd Compare

April 8, 2026 19:32

meta-codesync bot pushed a commit that referenced this pull request


          Add dual-conv tests for add/sub dual-input ifm scaling (#18755)

0d897ff

Summary:

Add AddDualConv and SubDualConv test models (conv1(x) +/- conv2(x)) where both inputs of the Add/Sub have Rescale producers.

Differential Revision: D99934624

3l1 added a commit that referenced this pull request


          Add dual-conv tests for add/sub dual-input ifm scaling (#18755)

76b4741

Summary:
Pull Request resolved: #18755

Add AddDualConv and SubDualConv test models (conv1(x) +/- conv2(x)) where both inputs of the Add/Sub have Rescale producers.

Differential Revision: D99934624

3l1 force-pushed the export-D99934624 branch from ea551bd to 76b4741 Compare

April 8, 2026 19:35

meta-codesync bot pushed a commit that referenced this pull request


          Add dual-conv tests for add/sub dual-input ifm scaling (#18755)

8b1e4ce

Summary:

Add AddDualConv and SubDualConv test models (conv1(x) +/- conv2(x)) where both inputs of the Add/Sub have Rescale producers.

Differential Revision: D99934624

meta-codesync bot force-pushed the export-D99934624 branch from 76b4741 to 8b1e4ce Compare

April 8, 2026 19:35

meta-codesync bot pushed a commit that referenced this pull request


          Add dual-conv tests for add/sub dual-input ifm scaling (#18755)

c4861a0

Summary:

Add AddDualConv and SubDualConv test models (conv1(x) +/- conv2(x)) where both inputs of the Add/Sub have Rescale producers.

Differential Revision: D99934624

3l1 requested a review from Ninja91

April 8, 2026 19:37


          Add conv+residual tests for Add/Sub ResolveAddSubScaling

adefe55

Summary:
Add AddConvResidual and SubConvResidual test models (conv(x) + x, conv(x) - x)
that exercise the ResolveAddSubScaling pass. The existing standalone Add/Sub
tests (x+x, x+y) always have unit IFM scales and never trigger the advanced
scaling path — these new tests create non-unit fused IFM scales via the
conv→rescale→add/sub fusion pipeline.

Differential Revision: D99927633

meta-codesync bot pushed a commit that referenced this pull request


          Add dual-conv tests for add/sub dual-input ifm scaling (#18755)

0fc08b0

Summary:

Add AddDualConv and SubDualConv test models (conv1(x) +/- conv2(x)) where both inputs of the Add/Sub have Rescale producers.

Differential Revision: D99934624

meta-codesync bot pushed a commit that referenced this pull request


          Add dual-conv tests for add/sub dual-input ifm scaling (#18755)

477d218

Summary:

Add AddDualConv and SubDualConv test models (conv1(x) +/- conv2(x)) where both inputs of the Add/Sub have Rescale producers.

Differential Revision: D99934624

meta-codesync bot force-pushed the export-D99934624 branch from 8b1e4ce to 477d218 Compare

April 8, 2026 21:51


          Add dual-conv tests for add/sub dual-input ifm scaling (#18755)

5634b27

Summary:
Pull Request resolved: #18755

Add AddDualConv and SubDualConv test models (conv1(x) +/- conv2(x)) where both inputs of the Add/Sub have Rescale producers.

Differential Revision: D99934624

3l1 force-pushed the export-D99934624 branch from 477d218 to 5634b27 Compare

April 8, 2026 21:56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported meta-exported