Add multi-reader tests for add/sub ifm scaling (#18758)#18758
Open
Add multi-reader tests for add/sub ifm scaling (#18758)#18758
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/18758
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 3 Unrelated FailuresAs of commit 97ed9fa with merge base 21d9c64 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
This PR needs a
|
meta-codesync
bot
changed the title
meta-codesync
bot
force-pushed
the
export-D99939008
branch
from
38ceb8f to
a51acc0
Compare
meta-codesync bot
pushed a commit
that referenced
this pull request
Apr 8, 2026
Summary: Add AddMultiReader and SubMultiReader test models (conv2(conv1(x)) +/- conv3(conv1(x))) where conv1's output Rescale has two readers. Differential Revision: D99939008
3l1
added a commit
that referenced
this pull request
Apr 8, 2026
Summary: Pull Request resolved: #18758 Add AddMultiReader and SubMultiReader test models (conv2(conv1(x)) +/- conv3(conv1(x))) where conv1's output Rescale has two readers. Differential Revision: D99939008
meta-codesync
bot
changed the title
meta-codesync bot
pushed a commit
that referenced
this pull request
Apr 8, 2026
Summary: Add AddMultiReader and SubMultiReader test models (conv2(conv1(x)) +/- conv3(conv1(x))) where conv1's output Rescale has two readers. Differential Revision: D99939008
meta-codesync
bot
force-pushed
the
export-D99939008
branch
from
03fde09 to
7b2d20c
Compare
3l1
added a commit
that referenced
this pull request
Apr 8, 2026
Summary: Pull Request resolved: #18758 Add AddMultiReader and SubMultiReader test models (conv2(conv1(x)) +/- conv3(conv1(x))) where conv1's output Rescale has two readers. Differential Revision: D99939008
meta-codesync
bot
force-pushed
the
export-D99939008
branch
from
1119e65 to
45e22a9
Compare
meta-codesync bot
pushed a commit
that referenced
this pull request
Apr 8, 2026
Summary: Add AddMultiReader and SubMultiReader test models (conv2(conv1(x)) +/- conv3(conv1(x))) where conv1's output Rescale has two readers. Differential Revision: D99939008
meta-codesync bot
pushed a commit
that referenced
this pull request
Apr 8, 2026
Summary: Add AddMultiReader and SubMultiReader test models (conv2(conv1(x)) +/- conv3(conv1(x))) where conv1's output Rescale has two readers. Differential Revision: D99939008
meta-codesync
bot
force-pushed
the
export-D99939008
branch
from
45e22a9 to
129c40e
Compare
3l1
added a commit
that referenced
this pull request
Apr 8, 2026
Summary: Pull Request resolved: #18758 Add AddMultiReader and SubMultiReader test models (conv2(conv1(x)) +/- conv3(conv1(x))) where conv1's output Rescale has two readers. Differential Revision: D99939008
Summary: Add AddConvResidual and SubConvResidual test models (conv(x) + x, conv(x) - x) that exercise the ResolveAddSubScaling pass. The existing standalone Add/Sub tests (x+x, x+y) always have unit IFM scales and never trigger the advanced scaling path — these new tests create non-unit fused IFM scales via the conv→rescale→add/sub fusion pipeline. Differential Revision: D99927633
Summary: Add AddDualConv and SubDualConv test models (conv1(x) +/- conv2(x)) where both inputs of the Add/Sub have Rescale producers. These exercise the dual-input path where both rescales are composed simultaneously. TOSA INT, U55 INT, U85 INT for both Add and Sub (6 new tests). Authored with Claude. Differential Revision: D99934624
meta-codesync
bot
force-pushed
the
export-D99939008
branch
from
4eb1659 to
c23a620
Compare
meta-codesync bot
pushed a commit
that referenced
this pull request
Apr 8, 2026
Summary: Add AddMultiReader and SubMultiReader test models (conv2(conv1(x)) +/- conv3(conv1(x))) where conv1's output Rescale has two readers. Differential Revision: D99939008
Summary: Pull Request resolved: #18758 Add AddMultiReader and SubMultiReader test models (conv2(conv1(x)) +/- conv3(conv1(x))) where conv1's output Rescale has two readers. Differential Revision: D99939008
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add AddMultiReader and SubMultiReader test models (conv2(conv1(x)) +/- conv3(conv1(x))) where conv1's output Rescale has two readers.
Differential Revision: D99939008