Skip to content

Fix empty FLAVOR in scheduled AAR builds #18764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kirklandsign merged 1 commit into from
Apr 8, 2026
+6 −2
Merged

Fix empty FLAVOR in scheduled AAR builds #18764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/android-release-artifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ jobs:
run: |
VERSION="${{ inputs.version }}"
FLAVOR="${{ inputs.flavor }}"
if [ -z "$FLAVOR" ]; then
FLAVOR="xnnpack"
fi
if [ -z "$VERSION" ]; then
echo "No version name specified. Will create a snapshot AAR"
echo "should-skip=false" >> $GITHUB_OUTPUT
Expand Down Expand Up @@ -115,9 +118,10 @@ jobs:
fi

FLAVOR="${{ inputs.flavor }}"
if [ ! -z "$FLAVOR" ]; then
GRADLE_ARGS+=" -Dflavor=${FLAVOR}"
if [ -z "$FLAVOR" ]; then
FLAVOR="xnnpack"
fi
GRADLE_ARGS+=" -Dflavor=${FLAVOR}"

if [[ "$FLAVOR" == "vulkan" || "$FLAVOR" == "all" || -z "$FLAVOR" ]]; then
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this job you now always set a default for FLAVOR (xnnpack) when it's empty, so the || -z "$FLAVOR" branch in the Vulkan setup condition is dead code and can be removed to avoid confusion about when Vulkan dependencies get installed.

Suggested change
if [[ "$FLAVOR" == "vulkan" || "$FLAVOR" == "all" || -z "$FLAVOR" ]]; then
if [[ "$FLAVOR" == "vulkan" || "$FLAVOR" == "all" ]]; then

Copilot uses AI. Check for mistakes.
curl -O https://sdk.lunarg.com/sdk/download/1.4.321.1/linux/vulkansdk-linux-x86_64-1.4.321.1.tar.xz
Expand Down
Loading