Skip to content

Use std::optional/string_view #20213

Open
cyyever wants to merge 1 commit into
pytorch:mainfrom
cyyever:std_opt
Open

Use std::optional/string_view #20213
cyyever wants to merge 1 commit into
pytorch:mainfrom
cyyever:std_opt

Conversation

@cyyever

@cyyever cyyever commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR changes callers to use std::optional/string_view.

Test plan

Check whether the system can build.

@pytorch-bot

pytorch-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20213

Note: Links to docs will display an error until the docs builds have been completed.

❌ 12 Pending, 1 Unclassified Failure

As of commit 9745d37 with merge base 875cc58 (image):

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 11, 2026
@cyyever

cyyever commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot Bot added the release notes: none Do not include this in the release notes label Jun 11, 2026
@rascani

rascani commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Thanks for making this change!

Does this remove all uses of torch::executor::optional and executorch::runtime::etensor::optional? If so, then it would probably be good to remove those type aliases to ensure new usages don't get re-introduced.

There are a few clang-format errors coming from lintrunner that need to be cleaned up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants