Skip to content

Arm backend: Test fixes for TOSA on Arm64#20237

Open
zingo wants to merge 3 commits into
pytorch:mainfrom
zingo:Arm-backend-Test-fixes-for-TOSA-on-Arm64
Open

Arm backend: Test fixes for TOSA on Arm64#20237
zingo wants to merge 3 commits into
pytorch:mainfrom
zingo:Arm-backend-Test-fixes-for-TOSA-on-Arm64

Conversation

@zingo

@zingo zingo commented Jun 12, 2026

Copy link
Copy Markdown
Collaborator

Signed-off-by: Zingo Andersen <Zingo.Andersen@arm.com>
Change-Id: Ia8b796cb91c92ff45b36478d3b6904b25314f00c
Copilot AI review requested due to automatic review settings June 12, 2026 13:11
@zingo zingo added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Jun 12, 2026
@zingo zingo requested a review from digantdesai as a code owner June 12, 2026 13:11
@zingo zingo added the release notes: none Do not include this in the release notes label Jun 12, 2026
@pytorch-bot

pytorch-bot Bot commented Jun 12, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/20237

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 6 New Failures, 10 Pending

As of commit ad6ed3a with merge base 5f71611 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 12, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels Jun 12, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts Arm backend model tests to account for known numeric mismatches on aarch64 when running TOSA FP/BF16 paths, reducing spurious CI failures on Arm64 hosts.

Changes:

  • Add an aarch64/arm64 host detection helper (common.is_aarch64_host()).
  • Mark the ResNet18 TOSA BF16 test as xfail on aarch64 due to a known mismatch (MLETORCH-2048).
  • Relax/xfail specific aarch64 cases for MobileNetV3 FP16 tolerance and Qwen3-VL BF16 vision patch embedding.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
backends/arm/test/common.py Adds is_aarch64_host() helper for host-conditional test behavior.
backends/arm/test/models/test_resnet18.py Xfails ResNet18 TOSA BF16 on aarch64 for known mismatch.
backends/arm/test/models/test_mobilenet_v3_arm.py Adjusts FP16 atol on aarch64 (and adds a clarifying comment).
backends/arm/test/models/Qwen3_VL/test_qwen3_vl_layers.py Adds per-case xfail for BF16 vision_patch_embed on aarch64.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread backends/arm/test/models/test_mobilenet_v3_arm.py Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 12, 2026 21:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants