Rename selective-build ROOT_OPS to SELECT_OPS_LIST - #21424
Rename selective-build ROOT_OPS to SELECT_OPS_LIST#21424sankalpsthakur wants to merge 2 commits into
Conversation
Align gen_selected_ops / gen_oplist naming with EXECUTORCH_SELECT_OPS_LIST so the cmake keyword is no longer a misnomer. Fixes pytorch#12133
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21424
Note: Links to docs will display an error until the docs builds have been completed.
|
|
Hi @sankalpsthakur! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
|
The following ciflow label(s) have been added but CI has not been triggered yet because the workflows are awaiting approval:
Once a maintainer approves the workflows (scroll to the bottom of the PR page), the corresponding CI jobs will be triggered automatically. Please ping one of the reviewers if you do not have access to approve and run workflows. |
This PR needs a
|
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
|
Hi @sankalpsthakur, thanks for putting up the fix! While we review this PR, please do sign the CLA agreements in order to approve & merge contributions in this repository. |
|
Thanks @nil-is-all — Meta CLA is signed (check green). EasyCLA is still showing unauthorized; I’m sorting that and pushed a lintrunner format fix for the SELECT_OPS_LIST call sites. |
Summary
gen_selected_opsCMake keywordROOT_OPStoSELECT_OPS_LISTto match the existingEXECUTORCH_SELECT_OPS_LISTcache option.gen_oplistCLI/API from--root_ops/root_opsto--select_ops_list/select_ops_list.Notes
gen_oplist.pystill prints the ops list to stdout (was print(root_ops)); left untouched to keep this PR rename-only.Validation
ROOT_OPS/--root_ops/root_opsreferences outside third-party.ast.parsesyntax check oncodegen/tools/gen_oplist.pyandcodegen/tools/test/test_gen_oplist.py.pytestfortest_gen_oplist.pynot run locally (requires ExecuTorch/torch install).Fixes #12133
AI/LLM disclosure
CLA
cc @mergennachin @nil-is-all @digantdesai @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell @rascani