migrate backends/aoti/slim/factory/test (fbcode-only GPU tests) by bigfootjon · Pull Request #21426 · pytorch/executorch

bigfootjon · 2026-07-28T16:15:11Z

Summary:
Add is_fbcode param to define_common_targets and early-return outside
fbcode. The cxx_test rules use fbcode-only kwargs (keep_gpu_sections,
re_test_utils.remote_execution) and were never evaluated in xplat
(TARGETS-only pre-migration). Replaced TARGETS with thin BUCK calling
define_common_targets(is_fbcode = is_fbcode()).

Differential Revision: D109082041

Summary: Chunk 10 of fbcode/executorch TARGETS->BUCK migration. 18 directories under examples/ where TARGETS defines targets like `python_library(name=X)` and the sister BUCK defines the same targets via the fbcode_target wrapper: `fbcode_target(_kind = python_library, name = X)`. Both forms produce the same logical target in fbcode; the wrapper just adds OSS-migration metadata. Confirmed every name= in TARGETS is also in BUCK. Deleting TARGETS lets fbcode fall through to BUCK (via name_v2 = TARGETS,BUCK) with no change in target inventory. Directories migrated: - examples/models - examples/models/{codegen,deeplab_v3,edsr,emformer_rnnt,glm,granite, inception_v3,mobilebert,mobilenet_v2,smollm2,smollm3,smolvlm, torchvision_vit,toy_model,wav2letter} - examples/portable/scripts - examples/xnnpack/quantization Differential Revision: D109082050

Summary: Chunk 11 of fbcode/executorch TARGETS->BUCK migration. 5 directories that had only a TARGETS file with substantive fbcode-only content but were skipped from earlier chunks for various reasons (`fbcode_target(`, `fbcode_macros`, fbcode-only kwargs, etc.). Same chunk-6 pattern: created `targets.bzl` with `define_common_targets(is_fbcode = False)` whose body opens with `if not is_fbcode: return`, replaced TARGETS with a thin BUCK calling `define_common_targets(is_fbcode = is_fbcode())`. Directories migrated: - backends/aoti/tests - backends/cuda/runtime - backends/cuda/tests - extension/pybindings/fb - extension/pytree/test Differential Revision: D109082053

Summary: Add is_fbcode param to define_common_targets and early-return outside fbcode. The cxx_test rules use fbcode-only kwargs (keep_gpu_sections, re_test_utils.remote_execution) and were never evaluated in xplat (TARGETS-only pre-migration). Replaced TARGETS with thin BUCK calling define_common_targets(is_fbcode = is_fbcode()). Differential Revision: D109082041

pytorch-bot · 2026-07-28T16:15:16Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21426

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit e27319d with merge base c7b6f52 ():

NEW FAILURES - The following jobs have failed:

Cadence Build & Test / hifi-build / hifi4 (gh)
Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
Cadence Build & Test / vision-build / vision (gh)
Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-codesync · 2026-07-28T16:16:11Z

@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109082041.

github-actions · 2026-07-28T16:17:13Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot

Pull request overview

Migrates several Buck build packages from legacy TARGETS files to BUCK wrappers that delegate target definitions to targets.bzl, gating fbcode-only test targets behind is_fbcode() to avoid xplat evaluation. Also removes stale model deps from the examples/models aggregate target.

Changes:

Replace multiple TARGETS packages with thin BUCK files that call define_common_targets(is_fbcode = is_fbcode()).
Add/adjust targets.bzl files to early-return outside fbcode for fbcode-only test definitions.
Remove whisper/yolo26 deps from examples/models/BUCK (no corresponding Buck targets in this repo).

Reviewed changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
extension/pytree/test/targets.bzl	New shared target definition function gated by `is_fbcode`.
extension/pytree/test/TARGETS	Removed legacy `TARGETS` definitions.
extension/pytree/test/BUCK	New wrapper calling `define_common_targets(...)`.
examples/models/BUCK	Drop deps on non-existent Buck targets (`whisper`, `yolo26`).
backends/cuda/tests/targets.bzl	New gated CUDA test target definitions (remote GPU test included).
backends/cuda/tests/TARGETS	Removed legacy `TARGETS` definitions.
backends/cuda/tests/BUCK	New wrapper calling `define_common_targets(...)`.
backends/cuda/runtime/targets.bzl	New gated CUDA runtime + unit test targets moved from `TARGETS`.
backends/cuda/runtime/TARGETS	Removed legacy `TARGETS` definitions.
backends/cuda/runtime/BUCK	New wrapper calling `define_common_targets(...)`.
backends/aoti/tests/targets.bzl	New gated AOTI test targets moved from `TARGETS`.
backends/aoti/tests/TARGETS	Removed legacy `TARGETS` definitions.
backends/aoti/tests/BUCK	New wrapper calling `define_common_targets(...)`.
backends/aoti/slim/factory/test/targets.bzl	Update `define_common_targets` to accept `is_fbcode` + early-return outside fbcode.
backends/aoti/slim/factory/test/TARGETS	Removed legacy `TARGETS` wrapper.
backends/aoti/slim/factory/test/BUCK	New wrapper calling `define_common_targets(...)`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
+load("@fbcode_macros//build_defs:python_unittest.bzl", "python_unittest")
+load("@fbcode_macros//build_defs:python_unittest_remote_gpu.bzl", "python_unittest_remote_gpu")
+load("@fbcode_macros//build_defs/lib:re_test_utils.bzl", "re_test_utils")


+        deps = [
+            ":cuda_platform",
+            ":runtime_shims",
+            ":cuda_allocator",
+            ":cuda_platform",
+            "//executorch/backends/aoti:aoti_common_slim",


+            "//executorch/runtime/core/exec_aten/testing_util:tensor_util",
+            "//executorch/runtime/core/exec_aten:lib",
+            "//executorch/extension/tensor:tensor",
+        ],


ndmitchell

Review automatically exported from Phabricator review in Meta.

bigfootjon added 3 commits July 28, 2026 08:55

Copilot AI review requested due to automatic review settings July 28, 2026 16:15

bigfootjon requested a review from JacobSzwejbka as a code owner July 28, 2026 16:15

meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 28, 2026

meta-codesync Bot added the meta-exported label Jul 28, 2026

meta-codesync Bot had a problem deploying to cadence July 28, 2026 16:16 Failure

Copilot started reviewing on behalf of bigfootjon July 28, 2026 16:16 View session

Copilot AI reviewed Jul 28, 2026

View reviewed changes

ndmitchell approved these changes Jul 28, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

migrate backends/aoti/slim/factory/test (fbcode-only GPU tests) - #21426

migrate backends/aoti/slim/factory/test (fbcode-only GPU tests)#21426
bigfootjon wants to merge 3 commits into
pytorch:mainfrom
bigfootjon:export-D109082041

bigfootjon commented Jul 28, 2026

Uh oh!

pytorch-bot Bot commented Jul 28, 2026 •

edited

Loading

Uh oh!

meta-codesync Bot commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

ndmitchell left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

bigfootjon commented Jul 28, 2026

Uh oh!

pytorch-bot Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21426

❌ 2 New Failures

Uh oh!

meta-codesync Bot commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

This PR needs a release notes: label

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

ndmitchell left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pytorch-bot Bot commented Jul 28, 2026 •

edited

Loading

This PR needs a `release notes:` label