migrate backends/cuda/runtime/shims/tests (fbcode-only CUDA tests) by bigfootjon · Pull Request #21427 · pytorch/executorch

bigfootjon · 2026-07-28T16:15:23Z

Summary:
Add is_fbcode early-return to existing define_common_targets. The cpp_unittest
rules use fbcode-only kwargs (keep_gpu_sections, re_test_utils.remote_execution)
and can't run in xplat. Replaced TARGETS with thin BUCK.

Differential Revision: D109082049

Summary: Chunk 11 of fbcode/executorch TARGETS->BUCK migration. 5 directories that had only a TARGETS file with substantive fbcode-only content but were skipped from earlier chunks for various reasons (`fbcode_target(`, `fbcode_macros`, fbcode-only kwargs, etc.). Same chunk-6 pattern: created `targets.bzl` with `define_common_targets(is_fbcode = False)` whose body opens with `if not is_fbcode: return`, replaced TARGETS with a thin BUCK calling `define_common_targets(is_fbcode = is_fbcode())`. Directories migrated: - backends/aoti/tests - backends/cuda/runtime - backends/cuda/tests - extension/pybindings/fb - extension/pytree/test Differential Revision: D109082053

Summary: Add is_fbcode param to define_common_targets and early-return outside fbcode. The cxx_test rules use fbcode-only kwargs (keep_gpu_sections, re_test_utils.remote_execution) and were never evaluated in xplat (TARGETS-only pre-migration). Replaced TARGETS with thin BUCK calling define_common_targets(is_fbcode = is_fbcode()). Differential Revision: D109082041

Summary: Add is_fbcode early-return to existing define_common_targets. The cpp_unittest rules use fbcode-only kwargs (keep_gpu_sections, re_test_utils.remote_execution) and can't run in xplat. Replaced TARGETS with thin BUCK. Differential Revision: D109082049

pytorch-bot · 2026-07-28T16:15:27Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21427

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 580f947 with merge base c7b6f52 ():

NEW FAILURES - The following jobs have failed:

Cadence Build & Test / hifi-build / hifi4 (gh)
Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
Cadence Build & Test / vision-build / vision (gh)
Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / test-qnn-testsuite-linux / test-backend-linux (qnn, models) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-codesync · 2026-07-28T16:16:18Z

@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109082049.

github-actions · 2026-07-28T16:17:45Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot

Pull request overview

This PR migrates several Buck TARGETS-only test directories to a BUCK + targets.bzl pattern, while gating fbcode-only test rules behind an is_fbcode early-return so xplat evaluation preserves prior behavior (i.e., these targets are not defined outside fbcode).

Changes:

Added define_common_targets(is_fbcode=...) wrappers (with early return) for multiple test directories that rely on fbcode-only macros/kwargs.
Replaced TARGETS files with thin BUCK files that call into targets.bzl.
Introduced/updated CUDA/AOTI-related target definitions under the new structure.

Reviewed changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
extension/pytree/test/targets.bzl	Defines pytree C++/Python unit tests behind an `is_fbcode` guard.
extension/pytree/test/TARGETS	Removed legacy `TARGETS`-based definitions.
extension/pytree/test/BUCK	Thin entrypoint calling `define_common_targets(is_fbcode = is_fbcode())`.
backends/cuda/tests/targets.bzl	Defines CUDA python unittests (incl. remote GPU test) behind `is_fbcode` guard.
backends/cuda/tests/TARGETS	Removed legacy `TARGETS`-based definitions.
backends/cuda/tests/BUCK	Thin entrypoint calling into `targets.bzl`.
backends/cuda/runtime/targets.bzl	Defines CUDA runtime libraries + C++ unittests behind `is_fbcode` guard.
backends/cuda/runtime/TARGETS	Removed legacy `TARGETS`-based definitions.
backends/cuda/runtime/BUCK	Thin entrypoint calling into `targets.bzl`.
backends/cuda/runtime/shims/tests/targets.bzl	Updates common-target definition to accept `is_fbcode` and early-return.
backends/cuda/runtime/shims/tests/TARGETS	Removed legacy `TARGETS`-based definitions.
backends/cuda/runtime/shims/tests/BUCK	Thin entrypoint calling into `targets.bzl`.
backends/aoti/tests/targets.bzl	Defines AOTI C++ unittests behind `is_fbcode` guard.
backends/aoti/tests/TARGETS	Removed legacy `TARGETS`-based definitions.
backends/aoti/tests/BUCK	Thin entrypoint calling into `targets.bzl`.
backends/aoti/slim/factory/test/targets.bzl	Updates SlimTensor factory tests to accept `is_fbcode` and early-return.
backends/aoti/slim/factory/test/TARGETS	Removed legacy `TARGETS`-based definitions.
backends/aoti/slim/factory/test/BUCK	Thin entrypoint calling into `targets.bzl`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
+load("@fbcode_macros//build_defs:python_unittest.bzl", "python_unittest")
+load("@fbcode_macros//build_defs:python_unittest_remote_gpu.bzl", "python_unittest_remote_gpu")
+load("@fbcode_macros//build_defs/lib:re_test_utils.bzl", "re_test_utils")
+


    """Defines targets that should be shared between fbcode and xplat.

-    The directory containing this targets.bzl file should also contain both
-    TARGETS and BUCK files that call this function.
+    Uses fbcode-only macros (cpp_unittest, re_test_utils) and kwargs
+    (keep_gpu_sections), so we early-return outside fbcode to preserve
+    pre-migration behavior (this dir was originally TARGETS-only).


+        deps = [
+            ":cuda_platform",
+            ":runtime_shims",
+            ":cuda_allocator",
+            ":cuda_platform",
+            "//executorch/backends/aoti:aoti_common_slim",


+        deps = [
+            "//executorch/backends/aoti:common_shims",
+            "//executorch/extension/tensor:tensor",
+            "//executorch/runtime/core:core",
+            "//executorch/runtime/platform:platform",
+            "//executorch/runtime/core/exec_aten/testing_util:tensor_util",
+            "//executorch/runtime/core/exec_aten:lib",
+            "//executorch/extension/tensor:tensor",
+        ],


ndmitchell

Review automatically exported from Phabricator review in Meta.

bigfootjon added 3 commits July 28, 2026 08:55

Copilot AI review requested due to automatic review settings July 28, 2026 16:15

bigfootjon requested a review from JacobSzwejbka as a code owner July 28, 2026 16:15

meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 28, 2026

Copilot started reviewing on behalf of bigfootjon July 28, 2026 16:16 View session

meta-codesync Bot added the meta-exported label Jul 28, 2026

meta-codesync Bot had a problem deploying to cadence July 28, 2026 16:16 Failure

Copilot AI reviewed Jul 28, 2026

View reviewed changes

ndmitchell approved these changes Jul 28, 2026

View reviewed changes

SS-JIA approved these changes Jul 29, 2026

View reviewed changes

meta-codesync Bot merged commit 8a19761 into pytorch:main Jul 29, 2026
218 of 230 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

migrate backends/cuda/runtime/shims/tests (fbcode-only CUDA tests) - #21427

migrate backends/cuda/runtime/shims/tests (fbcode-only CUDA tests)#21427
meta-codesync[bot] merged 3 commits into
pytorch:mainfrom
bigfootjon:export-D109082049

bigfootjon commented Jul 28, 2026

Uh oh!

pytorch-bot Bot commented Jul 28, 2026 •

edited

Loading

Uh oh!

meta-codesync Bot commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

ndmitchell left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

bigfootjon commented Jul 28, 2026

Uh oh!

pytorch-bot Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21427

❌ 2 New Failures, 1 Unrelated Failure

Uh oh!

meta-codesync Bot commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

This PR needs a release notes: label

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

ndmitchell left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

pytorch-bot Bot commented Jul 28, 2026 •

edited

Loading

This PR needs a `release notes:` label