drop empty TARGETS in backends/mediatek/runtime by bigfootjon · Pull Request #21430 · pytorch/executorch

bigfootjon · 2026-07-28T16:16:11Z

Summary:
The TARGETS file was 0 bytes; BUCK defines the actual neuron_backend
cxx_library targeting Android. fbcode now falls through to BUCK with no
behavior change.

Differential Revision: D109082047

Summary: Chunk 11 of fbcode/executorch TARGETS->BUCK migration. 5 directories that had only a TARGETS file with substantive fbcode-only content but were skipped from earlier chunks for various reasons (`fbcode_target(`, `fbcode_macros`, fbcode-only kwargs, etc.). Same chunk-6 pattern: created `targets.bzl` with `define_common_targets(is_fbcode = False)` whose body opens with `if not is_fbcode: return`, replaced TARGETS with a thin BUCK calling `define_common_targets(is_fbcode = is_fbcode())`. Directories migrated: - backends/aoti/tests - backends/cuda/runtime - backends/cuda/tests - extension/pybindings/fb - extension/pytree/test Differential Revision: D109082053

Summary: Add is_fbcode param to define_common_targets and early-return outside fbcode. The cxx_test rules use fbcode-only kwargs (keep_gpu_sections, re_test_utils.remote_execution) and were never evaluated in xplat (TARGETS-only pre-migration). Replaced TARGETS with thin BUCK calling define_common_targets(is_fbcode = is_fbcode()). Differential Revision: D109082041

Summary: Add is_fbcode early-return to existing define_common_targets. The cpp_unittest rules use fbcode-only kwargs (keep_gpu_sections, re_test_utils.remote_execution) and can't run in xplat. Replaced TARGETS with thin BUCK. Differential Revision: D109082049

Summary: Add is_fbcode early-return; replace TARGETS with thin BUCK. Differential Revision: D109082042

Summary: TARGETS contained fbcode-only Python rules (placeholder backend imports); BUCK contained xplat-only Apple platform cxx_library targets. Created a new targets.bzl with define_common_targets(is_fbcode = False) whose body splits via if/else: fbcode branch holds the Python rules, xplat branch holds the Apple cxx targets. Replaced BUCK with thin caller, deleted TARGETS. Differential Revision: D109082057

Summary: The TARGETS file was 0 bytes; BUCK defines the actual neuron_backend cxx_library targeting Android. fbcode now falls through to BUCK with no behavior change. Differential Revision: D109082047

pytorch-bot · 2026-07-28T16:16:16Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21430

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit d9e734c with merge base c7b6f52 ():

NEW FAILURES - The following jobs have failed:

Cadence Build & Test / hifi-build / hifi4 (gh)
Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
Cadence Build & Test / vision-build / vision (gh)
Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
pull / unittest-buck / linux / linux-job (gh)
RuntimeError: Command docker exec -t e0d70ffdf43fa3ef6c8d775364b47383c00df0ccfc088c2c9c535083e9a6340c /exec failed with exit code 3
pull / unittest-buck / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 3

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-codesync · 2026-07-28T16:17:17Z

@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109082047.

Copilot

Pull request overview

This PR continues the TARGETS→BUCK migration by moving fbcode-only targets into targets.bzl helpers (invoked from BUCK), and removing now-redundant TARGETS files. It also removes the (previously empty) backends/mediatek/runtime/TARGETS so fbcode falls through to BUCK, while keeping the runtime library gated as non-fbcode.

Changes:

Add per-directory targets.bzl + BUCK entrypoints and delete legacy TARGETS files for several test/runtime packages.
Gate fbcode-only test targets behind is_fbcode to preserve prior “TARGETS-only” behavior.
Remove empty backends/mediatek/runtime/TARGETS and wrap the Android Mediatek runtime target with non_fbcode_target.

Reviewed changes

Copilot reviewed 25 out of 26 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
extension/pytree/test/targets.bzl	New fbcode-gated test target definitions extracted from legacy TARGETS.
extension/pytree/test/TARGETS	Deleted (migrated into targets.bzl + BUCK).
extension/pytree/test/BUCK	New entrypoint that calls `define_common_targets(is_fbcode=...)`.
examples/models/llama/config/targets.bzl	Gate `python_unittest` target behind `is_fbcode` to preserve prior TARGETS-only semantics.
examples/models/llama/config/TARGETS	Deleted (replaced by BUCK calling targets.bzl).
examples/models/llama/config/BUCK	New entrypoint that calls `define_common_targets(is_fbcode=...)`.
backends/mediatek/runtime/TARGETS	Removed empty TARGETS so fbcode resolves via BUCK.
backends/mediatek/runtime/BUCK	Wrap `neuron_backend` definition with `non_fbcode_target` to preserve previous fbcode behavior.
backends/cuda/tests/targets.bzl	New fbcode-gated CUDA Python test target definitions extracted from legacy TARGETS.
backends/cuda/tests/TARGETS	Deleted (migrated into targets.bzl + BUCK).
backends/cuda/tests/BUCK	New entrypoint that calls `define_common_targets(is_fbcode=...)`.
backends/cuda/runtime/targets.bzl	New fbcode-gated CUDA runtime + unit test targets extracted from legacy TARGETS.
backends/cuda/runtime/TARGETS	Deleted (migrated into targets.bzl + BUCK).
backends/cuda/runtime/BUCK	New entrypoint that calls `define_common_targets(is_fbcode=...)`.
backends/cuda/runtime/shims/tests/targets.bzl	Add `is_fbcode` gating to preserve prior TARGETS-only behavior.
backends/cuda/runtime/shims/tests/TARGETS	Deleted (replaced by BUCK calling targets.bzl).
backends/cuda/runtime/shims/tests/BUCK	New entrypoint that calls `define_common_targets(is_fbcode=...)`.
backends/apple/coreml/targets.bzl	Consolidate prior split (fbcode Python rules vs xplat Apple cxx rules) into a single `define_common_targets(is_fbcode=...)`.
backends/apple/coreml/TARGETS	Deleted (fbcode branch moved into targets.bzl).
backends/apple/coreml/BUCK	Simplified to call `define_common_targets(is_fbcode=...)` instead of inlining Apple rules.
backends/aoti/tests/targets.bzl	New fbcode-gated AOTI C++ test targets extracted from legacy TARGETS.
backends/aoti/tests/TARGETS	Deleted (migrated into targets.bzl + BUCK).
backends/aoti/tests/BUCK	New entrypoint that calls `define_common_targets(is_fbcode=...)`.
backends/aoti/slim/factory/test/targets.bzl	Add `is_fbcode` gating to preserve prior TARGETS-only behavior for slim factory tests.
backends/aoti/slim/factory/test/TARGETS	Deleted (replaced by BUCK calling targets.bzl).
backends/aoti/slim/factory/test/BUCK	New entrypoint that calls `define_common_targets(is_fbcode=...)`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+load("@fbcode_macros//build_defs:build_file_migration.bzl", "non_fbcode_target")
 load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")

 oncall("executorch")



github-actions · 2026-07-28T16:22:31Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

ndmitchell

Review automatically exported from Phabricator review in Meta.

bigfootjon added 6 commits July 28, 2026 08:55

migrate examples/models/llama/config (fbcode-only python_unittest)

4516079

Summary: Add is_fbcode early-return; replace TARGETS with thin BUCK. Differential Revision: D109082042

drop empty TARGETS in backends/mediatek/runtime

d9e734c

Summary: The TARGETS file was 0 bytes; BUCK defines the actual neuron_backend cxx_library targeting Android. fbcode now falls through to BUCK with no behavior change. Differential Revision: D109082047

Copilot AI review requested due to automatic review settings July 28, 2026 16:16

bigfootjon requested review from JacobSzwejbka and shoumikhin as code owners July 28, 2026 16:16

meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 28, 2026

Copilot started reviewing on behalf of bigfootjon July 28, 2026 16:17 View session

meta-codesync Bot added the meta-exported label Jul 28, 2026

meta-codesync Bot had a problem deploying to cadence July 28, 2026 16:17 Failure

Copilot AI reviewed Jul 28, 2026

View reviewed changes

Comment thread backends/mediatek/runtime/BUCK

Comment on lines +8 to 12

load("@fbcode_macros//build_defs:build_file_migration.bzl", "non_fbcode_target")

load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")

oncall("executorch")

ndmitchell approved these changes Jul 28, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

drop empty TARGETS in backends/mediatek/runtime - #21430

drop empty TARGETS in backends/mediatek/runtime#21430
bigfootjon wants to merge 6 commits into
pytorch:mainfrom
bigfootjon:export-D109082047

bigfootjon commented Jul 28, 2026

Uh oh!

pytorch-bot Bot commented Jul 28, 2026 •

edited

Loading

Uh oh!

meta-codesync Bot commented Jul 28, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

ndmitchell left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

bigfootjon commented Jul 28, 2026

Uh oh!

pytorch-bot Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21430

❌ 4 New Failures

Uh oh!

meta-codesync Bot commented Jul 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

github-actions Bot commented Jul 28, 2026

This PR needs a release notes: label

Uh oh!

ndmitchell left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pytorch-bot Bot commented Jul 28, 2026 •

edited

Loading

This PR needs a `release notes:` label