migrate backends/vulkan/test (fbcode python_unittest + xplat fb_native) by bigfootjon · Pull Request #21431 · pytorch/executorch

bigfootjon · 2026-07-28T16:16:33Z

Summary:
TARGETS had fbcode-only python_unittest rules; BUCK had xplat fb_native
filegroup + define_compute_api_test_targets() call. Combined into a new
targets.bzl with if/else split on is_fbcode.

Differential Revision: D109082043

cc @SS-JIA @manuelcandales @digantdesai @cbilgin

Summary: Chunk 11 of fbcode/executorch TARGETS->BUCK migration. 5 directories that had only a TARGETS file with substantive fbcode-only content but were skipped from earlier chunks for various reasons (`fbcode_target(`, `fbcode_macros`, fbcode-only kwargs, etc.). Same chunk-6 pattern: created `targets.bzl` with `define_common_targets(is_fbcode = False)` whose body opens with `if not is_fbcode: return`, replaced TARGETS with a thin BUCK calling `define_common_targets(is_fbcode = is_fbcode())`. Directories migrated: - backends/aoti/tests - backends/cuda/runtime - backends/cuda/tests - extension/pybindings/fb - extension/pytree/test Differential Revision: D109082053

Summary: Add is_fbcode param to define_common_targets and early-return outside fbcode. The cxx_test rules use fbcode-only kwargs (keep_gpu_sections, re_test_utils.remote_execution) and were never evaluated in xplat (TARGETS-only pre-migration). Replaced TARGETS with thin BUCK calling define_common_targets(is_fbcode = is_fbcode()). Differential Revision: D109082041

Summary: Add is_fbcode early-return to existing define_common_targets. The cpp_unittest rules use fbcode-only kwargs (keep_gpu_sections, re_test_utils.remote_execution) and can't run in xplat. Replaced TARGETS with thin BUCK. Differential Revision: D109082049

Summary: Add is_fbcode early-return; replace TARGETS with thin BUCK. Differential Revision: D109082042

Summary: TARGETS contained fbcode-only Python rules (placeholder backend imports); BUCK contained xplat-only Apple platform cxx_library targets. Created a new targets.bzl with define_common_targets(is_fbcode = False) whose body splits via if/else: fbcode branch holds the Python rules, xplat branch holds the Apple cxx targets. Replaced BUCK with thin caller, deleted TARGETS. Differential Revision: D109082057

Summary: The TARGETS file was 0 bytes; BUCK defines the actual neuron_backend cxx_library targeting Android. fbcode now falls through to BUCK with no behavior change. Differential Revision: D109082047

Summary: TARGETS had fbcode-only python_unittest rules; BUCK had xplat fb_native filegroup + define_compute_api_test_targets() call. Combined into a new targets.bzl with if/else split on is_fbcode. Differential Revision: D109082043

pytorch-bot · 2026-07-28T16:16:38Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21431

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit b3898f9 with merge base c7b6f52 ():

NEW FAILURES - The following jobs have failed:

Cadence Build & Test / hifi-build / hifi4 (gh)
Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
Cadence Build & Test / vision-build / vision (gh)
Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
pull / unittest-buck / linux / linux-job (gh)
RuntimeError: Command docker exec -t 6ffbf0a779546dd0c9a208c53f45f8cdc1a6e3b30f0ee9b3178e35a74a2e08b9 /exec failed with exit code 3
pull / unittest-buck / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 3

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-codesync · 2026-07-28T16:17:31Z

@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109082043.

github-actions · 2026-07-28T16:18:20Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot

Pull request overview

This PR migrates several directories from fbcode-only TARGETS build files (and mixed TARGETS/BUCK setups) to a unified BUCK + targets.bzl pattern, using is_fbcode() to preserve the prior fbcode-vs-xplat behavior split. This aligns these test/build target definitions with the broader build-file migration approach used across the repo.

Changes:

Introduce new targets.bzl entrypoints that encapsulate fbcode vs xplat target definitions behind define_common_targets(is_fbcode=...).
Replace/retire TARGETS files in multiple locations, adding (or updating) BUCK files to call define_common_targets(...).
Wrap a MediaTek runtime library target with non_fbcode_target(...) to keep it non-fbcode-only during migration.

Reviewed changes

Copilot reviewed 28 out of 29 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
extension/pytree/test/targets.bzl	New shared target definitions (fbcode-only tests gated via `is_fbcode`).
extension/pytree/test/TARGETS	Removed legacy fbcode `TARGETS` definitions.
extension/pytree/test/BUCK	New BUCK entrypoint calling `define_common_targets(is_fbcode = is_fbcode())`.
examples/models/llama/config/targets.bzl	Gate fbcode-only `python_unittest` usage behind `is_fbcode` parameter.
examples/models/llama/config/TARGETS	Removed legacy TARGETS wrapper that invoked `define_common_targets()`.
examples/models/llama/config/BUCK	New BUCK entrypoint calling `define_common_targets(is_fbcode = is_fbcode())`.
backends/vulkan/test/targets.bzl	Consolidates fbcode Python unittests and xplat shader/filegroup + compute-api test targets into one `define_common_targets`.
backends/vulkan/test/TARGETS	Removed legacy fbcode `TARGETS` test definitions.
backends/vulkan/test/BUCK	Switched to calling `define_common_targets(is_fbcode = is_fbcode())` rather than defining xplat targets directly.
backends/mediatek/runtime/BUCK	Wraps the `neuron_backend` `runtime.cxx_library` with `non_fbcode_target(...)`.
backends/cuda/tests/targets.bzl	New fbcode-gated CUDA test targets moved from `TARGETS`.
backends/cuda/tests/TARGETS	Removed legacy `TARGETS` definitions for CUDA tests.
backends/cuda/tests/BUCK	New BUCK entrypoint calling `define_common_targets(is_fbcode = is_fbcode())`.
backends/cuda/runtime/targets.bzl	New fbcode-gated CUDA runtime + C++ unit tests moved from `TARGETS`.
backends/cuda/runtime/TARGETS	Removed legacy `TARGETS` definitions for CUDA runtime/test targets.
backends/cuda/runtime/shims/tests/targets.bzl	Updates `define_common_targets` to accept `is_fbcode` and early-return outside fbcode.
backends/cuda/runtime/shims/tests/TARGETS	Removed legacy TARGETS wrapper invoking `define_common_targets()`.
backends/cuda/runtime/shims/tests/BUCK	New BUCK entrypoint calling `define_common_targets(is_fbcode = is_fbcode())`.
backends/cuda/runtime/BUCK	New BUCK entrypoint calling `define_common_targets(is_fbcode = is_fbcode())`.
backends/apple/coreml/targets.bzl	New combined fbcode + xplat target definitions, preserving the prior split via `is_fbcode`.
backends/apple/coreml/TARGETS	Removed legacy fbcode TARGETS definitions.
backends/apple/coreml/BUCK	Reduced to a dispatcher that calls `define_common_targets(is_fbcode = is_fbcode())`.
backends/aoti/tests/targets.bzl	New fbcode-gated AOTI test targets moved from `TARGETS`.
backends/aoti/tests/TARGETS	Removed legacy `TARGETS` definitions for AOTI tests.
backends/aoti/tests/BUCK	New BUCK entrypoint calling `define_common_targets(is_fbcode = is_fbcode())`.
backends/aoti/slim/factory/test/targets.bzl	Gates prior fbcode-only test definitions via `is_fbcode` param + early return.
backends/aoti/slim/factory/test/TARGETS	Removed legacy TARGETS wrapper invoking `define_common_targets()`.
backends/aoti/slim/factory/test/BUCK	New BUCK entrypoint calling `define_common_targets(is_fbcode = is_fbcode())`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ndmitchell

Review automatically exported from Phabricator review in Meta.

bigfootjon added 7 commits July 28, 2026 08:55

migrate examples/models/llama/config (fbcode-only python_unittest)

4516079

Summary: Add is_fbcode early-return; replace TARGETS with thin BUCK. Differential Revision: D109082042

drop empty TARGETS in backends/mediatek/runtime

03bc3a4

Summary: The TARGETS file was 0 bytes; BUCK defines the actual neuron_backend cxx_library targeting Android. fbcode now falls through to BUCK with no behavior change. Differential Revision: D109082047

Copilot AI review requested due to automatic review settings July 28, 2026 16:16

bigfootjon requested review from JacobSzwejbka, SS-JIA and shoumikhin as code owners July 28, 2026 16:16

pytorch-bot Bot added the module: vulkan Issues related to the Vulkan delegate and code under backends/vulkan/ label Jul 28, 2026

meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 28, 2026

Copilot started reviewing on behalf of bigfootjon July 28, 2026 16:17 View session

meta-codesync Bot added the meta-exported label Jul 28, 2026

meta-codesync Bot had a problem deploying to cadence July 28, 2026 16:17 Failure

Copilot AI reviewed Jul 28, 2026

View reviewed changes

ndmitchell approved these changes Jul 28, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

migrate backends/vulkan/test (fbcode python_unittest + xplat fb_native) - #21431

migrate backends/vulkan/test (fbcode python_unittest + xplat fb_native)#21431
bigfootjon wants to merge 7 commits into
pytorch:mainfrom
bigfootjon:export-D109082043

bigfootjon commented Jul 28, 2026 •

edited by pytorch-bot Bot

Loading

Uh oh!

pytorch-bot Bot commented Jul 28, 2026 •

edited

Loading

Uh oh!

meta-codesync Bot commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

ndmitchell left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

bigfootjon commented Jul 28, 2026 • edited by pytorch-bot Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21431

❌ 4 New Failures

Uh oh!

meta-codesync Bot commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

This PR needs a release notes: label

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

ndmitchell left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bigfootjon commented Jul 28, 2026 •

edited by pytorch-bot Bot

Loading

pytorch-bot Bot commented Jul 28, 2026 •

edited

Loading

This PR needs a `release notes:` label