Skip to content

Qualcomm AI Engine Direct - Remove unused callable dataset branch - #21461

Open
DannyYuyang-quic wants to merge 1 commit into
pytorch:mainfrom
CodeLinaro:dev1/danny/rm_unused_callable_dataset
Open

Qualcomm AI Engine Direct - Remove unused callable dataset branch#21461
DannyYuyang-quic wants to merge 1 commit into
pytorch:mainfrom
CodeLinaro:dev1/danny/rm_unused_callable_dataset

Conversation

@DannyYuyang-quic

@DannyYuyang-quic DannyYuyang-quic commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Drop Callable from the type hint and docstring, and remove the dead callable(dataset) branch in _ptq_calibrate.

Test plan

General CI

Summary:
- Drop Callable from the type hint and docstring, and remove the dead
  callable(dataset) branch in _ptq_calibrate.
@pytorch-bot

pytorch-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21461

Note: Links to docs will display an error until the docs builds have been completed.

❌ You can merge normally! (2 Unrelated Failures), 1 Unclassified Failure

As of commit 29f1f24 with merge base 80925df (image):

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

  • periodic (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 29, 2026
@DannyYuyang-quic

Copy link
Copy Markdown
Contributor Author

@pytorchbot label "release notes: qualcomm"

@pytorch-bot pytorch-bot Bot added the release notes: qualcomm Changes to the Qualcomm backend delegate label Jul 29, 2026
@DannyYuyang-quic

Copy link
Copy Markdown
Contributor Author

@psiddh Hi, Callable dataset was never usable, input = dataset[0] at torch.export.export would crash first so the branch was dead code and the type hint was misleading; removed both.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: qualcomm Changes to the Qualcomm backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants