Skip to content

NXP backend: fixed docs in nxp-quantization.md - #21464

Merged
robert-kalmar merged 2 commits into
pytorch:mainfrom
nxp-upstream:docs/EIEX-991-fix-docs-example
Jul 29, 2026
Merged

NXP backend: fixed docs in nxp-quantization.md#21464
robert-kalmar merged 2 commits into
pytorch:mainfrom
nxp-upstream:docs/EIEX-991-fix-docs-example

Conversation

@novak-vaclav

@novak-vaclav novak-vaclav commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

Fixed code snippets in nxp-quantization.md.

  • there was an issue with faulty imports, where some kernels were not registered properly.
  • added missing neutron_target_spec argument.
  • here was another issue with the snippet for QAT. I fixed the code so it can be copy-pasted and run directly. I also removed the optional biasless convolution pass step. It makes the whole snippet quite misleading, since the example MobileNet does not have biasless convolutions, thus the code fails. I think the whole caveat is understandable from the last section about known limitations.
  • fixed invalid link.

Test plan

No need to run tests, these changes affect only docs.

cc @robert-kalmar @JakeStevens @digantdesai @rascani @MartinPavella @roman-janik-nxp

Copilot AI review requested due to automatic review settings July 29, 2026 16:13
@pytorch-bot

pytorch-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21464

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 3ca6a26 with merge base c6f166d (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 29, 2026
@linux-foundation-easycla

linux-foundation-easycla Bot commented Jul 29, 2026

Copy link
Copy Markdown

CLA Not Signed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@novak-vaclav novak-vaclav added module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate labels Jul 29, 2026
@roman-janik-nxp
roman-janik-nxp force-pushed the docs/EIEX-991-fix-docs-example branch from 4391934 to 3ca6a26 Compare July 29, 2026 17:46
Copilot AI review requested due to automatic review settings July 29, 2026 17:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review is ineligible. To be eligible to request a review, you need a paid Copilot license, or your organization must enable Copilot code review.

@roman-janik-nxp

Copy link
Copy Markdown
Collaborator

Rebased on recent main that includes fix for failing llama example in linux test check: c6f166d Fix test_text_decoder pytest collection collision

@roman-janik-nxp roman-janik-nxp left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robert-kalmar
robert-kalmar merged commit 85a204a into pytorch:main Jul 29, 2026
181 of 183 checks passed
@robert-kalmar

Copy link
Copy Markdown
Collaborator

@pytorchbot cherry-pick --onto release/1.4 -c docs

@pytorchbot

Copy link
Copy Markdown
Collaborator

Cherry picking #21464

The cherry pick PR is at #21472 The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@robert-kalmar
robert-kalmar deleted the docs/EIEX-991-fix-docs-example branch July 30, 2026 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants