Skip to content

force neon vectorization for ios (#21479) - #21479

Open
JakeStevens wants to merge 2 commits into
pytorch:mainfrom
JakeStevens:export-D113940046
Open

force neon vectorization for ios (#21479)#21479
JakeStevens wants to merge 2 commits into
pytorch:mainfrom
JakeStevens:export-D113940046

Conversation

@JakeStevens

@JakeStevens JakeStevens commented Jul 29, 2026 •
edited by meta-codesync Bot
Loading

Copy link
Copy Markdown
Contributor

Summary:

The default implementation auto-vectorized well for Android builds, but the specific LLVM Clang 21 toolchain + compiler flags did not auto-vectorize, resulting in only scalar operations.

This commit selectively forces neon vectorization for iOS

Differential Revision: D113940046

@pytorch-bot

pytorch-bot Bot commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21479

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 57e01dc with merge base f4a21b8 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 29, 2026
@meta-codesync

meta-codesync Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113940046.

@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@JakeStevens @facebook-github-bot
Support grouped state heads in GDN attention (pytorch#21402)
0136f7c 
Summary:

Adds separate query-head and state-head configuration to the model definition as well as updates the fused
channelwise_gated_delta_rule custom op to support grouped decode and prefill.

Differential Revision: D113299906
@JakeStevens @facebook-github-bot
force neon vectorization for ios (pytorch#21479)
57e01dc 
Summary:

The default implementation auto-vectorized well for Android builds, but the specific LLVM Clang 21 toolchain + compiler flags did not auto-vectorize, resulting in only scalar operations.

This commit selectively forces neon vectorization for iOS

Differential Revision: D113940046
@meta-codesync meta-codesync Bot changed the title force neon vectorization for ios force neon vectorization for ios (#21479) Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner
@mergennachin mergennachin Awaiting requested review from mergennachin mergennachin is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@JakeStevens