Only use chr(30) and chr(31) delimiters in cirq-ionq#7699
Only use chr(30) and chr(31) delimiters in cirq-ionq#7699mhucka merged 5 commits intoquantumlib:mainfrom
chr(30) and chr(31) delimiters in cirq-ionq#7699Conversation
splch
force-pushed
the
no-ctrl-chars-in-json
branch
from
f66d46b to
e8e79bb
Compare
github-actions
Bot
added
Size: XS
github-actions
Bot
added
size: S
splch
changed the title
k and t
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7699 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 1110 1110
Lines 99749 99749
=======================================
+ Hits 99386 99387 +1
+ Misses 363 362 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@splch Thank you for your work on this! When you get a chance, could you update the title of this PR to mention that this is for cirq-ionq, and also add a bit more explanation to the PR description? This will help future contributors and maintainers when reading and searching through past work. |
mhucka
changed the title
chr(30) and chr(31) delimiters in cirq-ionq
|
@splch I'm not sure if this draft PR is still something planned. It looks like the associated issue was closed. Maybe this should be closed too? (No biggie either way; just going around and checking up on things.) |
|
This pull request has been automatically labeled as stale because 90 days have passed without comments or other activity. If no further activity occurs and the If you have questions or feedback about this process, we welcome your input. You can open a new issue to let us know (please also reference this issue there, for continuity), or reach out to the project maintainers at quantum-oss-maintainers@google.com. |
github-actions
Bot
added
status/stale
|
@splch Gentle ping about the status of this PR … |
Convert all hand-escaped JSON string literals in serializer_test.py and service_test.py to use json.dumps() for consistency, and replace the last \u001f escape with chr(31).
github-actions
Bot
added
size: M
thank you for the ping!! just pushed this over the finish line haha |
mhucka
left a comment
mhucka
left a comment
There was a problem hiding this comment.
LGTM. Thanks again for doing this!
…7699) - [x] update tests to remove`\u*` and `\x*` relates to quantumlib#5216 --------- Co-authored-by: Michael Hucka <mhucka@caltech.edu>
2 participants
\u*and\x*relates to #5216