Naming Consistencies

[g0tmi1k]

DHClient

There is a lot more using env rather than environment for module names.
Plus there is already a auxiliary that does mostly the same (just doesn't use /etc/crontab):

$ find modules -name '*environment*.rb' | wc -l
       2
$ find modules -name '*env*.rb' | wc -l
      30
$
$ find . -name 'dhclient*'
./modules/auxiliary/server/dhclient_bash_env.rb
$

PXE

Making sure their names match as they are mostly the same with:

• exploits/windows/local/pxe_exploit
• auxiliary/server/pxe_exploit

At the same time, rather than it all being a single word, separating them out with _

Shellshock

• Variable Injection -> Variable Code Injection
• Making sure (Shellshock) (aka the codename) is at the end

[adfoster-r7]

As a note to the reviewer; when renaming modules we'll to add a pointer from the old name:

metasploit-framework/modules/exploits/multi/http/coldfusion_rds_auth_bypass.rb

Line 13 in fed897a

moved_from 'exploit/multi/http/coldfusion_rds'

And we'll want to verify none of these modules are very popular, as it can be confusing to users or break old guides when they change; similarly confirm that Metasploit Pro doesn't directly invoke these modules behind the scenes as that can also break things