Cleaned up version of Edatec HMI drivers#7383
Conversation
|
Thank you for your careful review. We are adjusting the code and conducting testing based on your feedback. I noticed that you have replaced gpio_chip with gpio_degmap_config. Is this a better choice as the default defconfig does not enable CONFIG_GPIO_REGMAP. |
Signed-off-by: lzunspp <bli@edatec.cn>
Signed-off-by: lzunspp <bli@edatec.cn>
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
…gulator Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
Modules should select their own dependencies via Kconfig rather than relying on the defconfig to include them.
|
|
Ok, I understand. Our previous choice of |
|
Also, a lot of redundant code from the original 10inch and 7inch driver had been deleted and we spend some time conducting tests. I will submit the driver update later today. |
My version of #7361 and #7362 actually using the various parts that I've requested.
I have no hardware to test it, but the behaviour should be the same.
I have not replicated the CM0 vs Pi4/CM4 timing difference for the 7" as I do not believe there needs to be one. It also avoids having to change the value for CMD_BRIDGE_INIT.
Patches need to be squashed/split appropriately before merge, hence draft.
@spp-bruk