Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds telemetry (T2) instrumentation to the connectivity-check path so connectivity failures and internet connect/disconnect outcomes are reported via telemetry events.
Changes:
- Conditionally includes the telemetry sender header when
USE_TELEMETRYis enabled. - Emits a string telemetry event on CURL connectivity failures, including endpoint and CURL error text.
- Emits numeric telemetry events for internet connected/disconnected outcomes derived from HTTP response analysis.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| #if USE_TELEMETRY | ||
| { | ||
| std::string t2value = std::string("endpoint: ") + (endpntConf ? endpntConf : "") + " curl error: " + curl_easy_strerror(msg->data.result); | ||
| t2_event_s("WIFIV_WARN_Connectivityfail", const_cast<char*>(t2value.c_str())); |
Comment on lines
526
to
+531
| case HttpStatus_204_No_Content: | ||
| InternetConnectionState = INTERNET_FULLY_CONNECTED; | ||
| NMLOG_INFO("Internet State: FULLY_CONNECTED - %.1f%%", (percentage*100)); | ||
| #if USE_TELEMETRY | ||
| t2_event_d("WIFI_INFO_INT_CON", 1); | ||
| #endif |
Comment on lines
+547
to
+557
| #if USE_TELEMETRY | ||
| t2_event_d("WIFI_INFO_INT_DISCON", 1); | ||
| #endif | ||
| } | ||
| else | ||
| { | ||
| NMLOG_WARNING("Internet State: NO_INTERNET (http code: %d - %.1f%%)", static_cast<int>(http_response_code), percentage * 100); | ||
| #if USE_TELEMETRY | ||
| t2_event_d("WIFI_INFO_INT_DISCON", 1); | ||
| #endif | ||
| } |
Comment on lines
546
to
+556
| NMLOG_ERROR("Internet State: NO_INTERNET (curl error)"); | ||
| #if USE_TELEMETRY | ||
| t2_event_d("WIFI_INFO_INT_DISCON", 1); | ||
| #endif | ||
| } | ||
| else | ||
| { | ||
| NMLOG_WARNING("Internet State: NO_INTERNET (http code: %d - %.1f%%)", static_cast<int>(http_response_code), percentage * 100); | ||
| #if USE_TELEMETRY | ||
| t2_event_d("WIFI_INFO_INT_DISCON", 1); | ||
| #endif |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.