fix: show subtitles on submenus - #1219
Draft
juliusmarminge wants to merge 2 commits into
Draft
Conversation
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
iOS currently applies
subtitleonly when an action becomes a leafUIAction. An action withsubactionsbecomes aUIMenu, so its subtitle is silently dropped.This assigns
UIMenu.subtitleon iOS 15+ and derives a stableUIMenu.Identifierfrom the action id for navigable submenus. Stable identifiers let UIKit match submenu nodes during in-place menu updates without returning the user to the root menu. Inline sections do not navigate, so they keep UIKit's stock identifier behavior.Related to #536, which reported missing iOS subtitles. Leaf action subtitles are supported today, but the submenu path remained unhandled.
Companion to #1220, which refreshes presented menus in place and relies on these stable identifiers to preserve the current submenu level.
Test Plan
yarn lintyarn typescriptyarn test --runInBandGenerated with OpenAI Codex (GPT-5) in T3 Code.