Fix broken anchor link for async components on the client#8484
Open
LuxologyGG wants to merge 1 commit into
Open
Fix broken anchor link for async components on the client#8484LuxologyGG wants to merge 1 commit into
LuxologyGG wants to merge 1 commit into
Conversation
Add the missing 'Why can't I use async components on the client?' section and link to it from the async components example. Fixes reactjs#7305
Size changesDetails📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #7305
The Server Components docs referenced a
#why-cant-i-use-async-components-on-the-clientanchor that did not exist, resulting in a broken in-page link.This PR adds the missing section with a
Noteexplaining why async components are a Server Component feature and how to useuse()on the client instead.Before / After
Before: Link to
#why-cant-i-use-async-components-on-the-clientwith no matching section on the page.After: Link resolves to a new
Notesection titled "Why can't I use async components on the client?" with the anchor{/*why-cant-i-use-async-components-on-the-client*/}.Type of change