Proposed 0.8 branch

[phpfui]

Proposed new branch 0.8

Drops support for PHP 7.0 and lower (only .7% current usage)

• Fix depreciation of typeless function parameters with a default of null. This will probably be enforced in PHP 9.0, so this change future proofs the library. The previous fix for 8.4 did not solve the problem.
• Drop support for 5.3 through 7.0. The current usage statistics from Packagist.org suggest no one is using PHP 5.3, 5.4 and 5.5. Usage of 5.6 and 7.0 is 0.7%. Users of 7.0 and lower can use the 0.7 branch.
• Drop support for PHPUnit less than 7.0. They are no longer supported anyway and no longer needed after dropping PHP 7.0 and lower support.
• Removed tests for InvalidArgumentException exceptions, as this is now enforced by PHP itself.
• Added return types for all functions including void based on DocBlocks or code inspection.
• Added typed parameters with null support for all functions based on DocBlocks
• Removed useless DocBlock comments when they just provided type information, as that information is now in the PHP code.

[mickverm]

I'm a fan of these changes, but I'm not sure why this should become a 0.8 if 0.7 hasn't even been released yet.

[phpfui]

I did not realize 0.7 was not released yet. I am not a direct user of this library, just another dependency for me.

But 0.7 works!

[mickverm]

@WyriHaximus I see you last worked on this project, any chance you could have a look at this PR?

[clue]

@phpfui Thanks for looking into this and filing this PR!

I think the suggested changes look perfectly reasonable. That said, I think we should also align this with the project roadmap as discussed in #31 and #106 and it looks like there's some confusion regarding PHP 8.4+ support as discussed in #110.

As a first step, I've just posted an update in #110 to make sure we can get out a release that supports PHP 8.4+ as already prepared in #108. Once #113 is merged, we can move forward with this.

In the meantime, I don't think there's much that needs to be done here. I'll get back to this once we make progress. What do you think about this? Thank you!

[phpfui]

I am happy to help in any way you need. I am retired, so I have the time. Let me know what you need. I did extensive work upgrading https://github.com/zbateson/mail-mime-parser if you want a reference.

I would suggest just supporting PHP 7.1 or higher. We really need to move the state of PHP forward and supporting very old unused versions of PHP does not help. I wrote about legacy PHP support a few years ago, but still relevant.

[WyriHaximus]

I would suggest just supporting PHP 7.1 or higher. We really need to move the state of PHP forward and supporting very old unused versions of PHP does not help. I wrote about legacy PHP support a few years ago, but still relevant.

We fully support this, this is why we're pushing to 7.1 with v3 and looking beyond that for v4: https://github.com/orgs/reactphp/discussions/481 But that isn't out yet due to a mix of personal and professional life events. Once v3 is out, v1 will stay in support for X months. So we would love to get there, but until it's out we keep v1 supported for new and currently supported PHP versions.

[phpfui]

Closing this as I believe it was fixed in another release.