Replace rector/type-perfect with tomasvotruba/type-coverage - #384
Merged
Conversation
Type-perfect rules moved into tomasvotruba/type-coverage 2.3.0. The type_perfect config key is unchanged, so phpstan.neon keeps its existing settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
type-perfectrules have moved intotomasvotruba/type-coverage2.3.0, which now ships them as a bundled package:So
rector/type-perfectis dropped andtomasvotruba/type-coverageadded in its place."require-dev": { - "rector/type-perfect": "^2.1", + "tomasvotruba/type-coverage": "^2.3", }The
type_perfectconfig key is unchanged, sophpstan.neonkeeps its existing settings as-is - only the doc link is updated:Note:
tomasvotruba/type-coverage2.3 requires PHP^8.4, one step above this package's"php": ">=8.3"runtime constraint. It is arequire-devonly, and every CI job here already runs on 8.4 or 8.5, same as the existingtomasvotruba/unused-publicdev dependency.The
type_coveragerules that come along in the same package report nothing here - the codebase is already above their default 99% thresholds.