Bump dev dependencies, PHPUnit 13 - #385
Merged
Merged
Conversation
Run composer update and vendor/bin/jack raise-to-installed, then composer fix-cs for the newer easy-coding-standard rules. PHPUnit 13 ignores a RequiresPhp version without a comparison operator, which made the PHP 8.5 only tests run everywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
composer update+vendor/bin/jack raise-to-installed, with PHPUnit taken from 11.5 to 13."require-dev": { - "phpstan/phpstan": "^2.1.33", + "phpstan/phpstan": "^2.2", - "phpunit/phpunit": "^11.5", + "phpunit/phpunit": "^13.2", - "rector/jack": "^0.5.1", + "rector/jack": "^1.0", - "rector/swiss-knife": "^2.3", + "rector/swiss-knife": "^2.4", - "symplify/easy-coding-standard": "^13.0", + "symplify/easy-coding-standard": "^13.2", - "symplify/phpstan-rules": "^14.9", + "symplify/phpstan-rules": "^14.12", - "tracy/tracy": "^2.11" + "tracy/tracy": "^2.12" }PHPUnit 13 pulls
sebastian/diff9, which needs rector-src04b18f6or newer (rectorphp/rector-src#8220).Two PHP 8.5 tests were running on every PHP version
PHPUnit 13 no longer honours a
RequiresPhpversion that has no comparison operator - it warns and ignores the requirement, so the PHP 8.5 only fixtures got parsed on 8.4 and blew up withSyntax error, unexpected T_VARIABLE.The second one also needed the patch level -
>= 8.5alone is reported as incomplete.Formatting
The remaining 16 files are
composer fix-csoutput for the newer easy-coding-standard - union type spacing,static fn, and!spacing: