Skip to content

Fix: Open .java file instead of .class during debugging when source is available #4375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amritamishra01 wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −2
Open

Fix: Open .java file instead of .class during debugging when source is available #4375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/javaClassEditor.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,22 @@ export class JavaClassEditorProvider implements vscode.CustomReadonlyEditorProvi
enableScripts: true,
localResourceRoots: [Uri.joinPath(Uri.parse(this.context.extensionPath), 'webview-resources')]
};
const classUri = Uri.parse((document.uri.toString()).replace(/^file/, "class"));
const uriString = document.uri?.toString();
let targetUri: Uri;

if (!uriString) {
targetUri = document.uri; // Fallback safety for null/undefined URIs
} else {
const fileUri = Uri.parse(uriString.replace(/^class/, "file"));
try {
// Attempt to open as a standard text document first
await vscode.workspace.openTextDocument(fileUri);
targetUri = fileUri;
} catch {
// Fallback to the 'class' scheme if the file document can't be opened
targetUri = Uri.parse(uriString.replace(/^file/, "class"));
}
}
const styleUri = Uri.file(
path.join(this.context.extensionPath, 'webview-resources', 'button.css')
);
Expand All @@ -52,7 +67,7 @@ export class JavaClassEditorProvider implements vscode.CustomReadonlyEditorProvi
switch (message.command) {
case 'decompiled':
webviewPanel.dispose();
window.showTextDocument(classUri, { preview: false });
window.showTextDocument(targetUri, { preview: false });
return;
}
}, undefined, this.context.subscriptions);
Expand Down