Admin API v2: add IcebergService (GetIcebergStatus) for 26.2#76
Open
kbatuigas wants to merge 1 commit into
Open
Admin API v2: add IcebergService (GetIcebergStatus) for 26.2#76kbatuigas wants to merge 1 commit into
kbatuigas wants to merge 1 commit into
Conversation
Regenerate admin/admin-v2.yaml from redpanda core v26.2.1-rc4, which adds the IcebergService/GetIcebergStatus endpoint (and the FeaturesService endpoints that also landed in 26.2). Add an IcebergService tag description and an "Added in v26.2" version badge for the new endpoint. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
🤖 Admin API (branch: v2) API structural change detectedStructural change detailsAdded (3)
Modified (5)
Powered by Bump.sh |
📝 WalkthroughWalkthroughThe Admin API v2 specification adds upgrade-finalization and upgrade-status models and routes, Iceberg catalog/topic/partition status reporting, and new shadow-link role and Schema Registry synchronization configuration and status schemas. Shadow-link creation now supports validation-only requests. The Iceberg endpoint is versioned and tagged in overlays, and the OpenAPI metadata is updated. Estimated code review effort: 4 (Complex) | ~45 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@admin/v2-overlays/add-endpoint-versioning.yaml`:
- Around line 92-95: Extend the v26.2 endpoint updates in the overlay to include
the FeaturesService paths for FinalizeUpgrade and GetUpgradeStatus, assigning
each the same x-state value, “Added in v26.2,” as the existing IcebergService
endpoint.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: cc276840-b3c2-4ec7-b4e7-3a42013f11b6
📒 Files selected for processing (3)
admin/admin-v2.yamladmin/v2-overlays/add-endpoint-versioning.yamladmin/v2-overlays/create-and-update-tags.yaml
Comment on lines
+92
to
+95
| # 26.2 endpoints | ||
| - target: "$.paths['/redpanda.core.admin.v2.IcebergService/GetIcebergStatus'].post" | ||
| update: | ||
| x-state: "Added in v26.2" No newline at end of file |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Version the new FeaturesService endpoints as v26.2 too.
FinalizeUpgrade and GetUpgradeStatus are also introduced at admin/admin-v2.yaml Lines 3335-3431, but only the Iceberg endpoint receives an x-state marker.
Proposed fix
# 26.2 endpoints
+ - target: "$.paths['/redpanda.core.admin.v2.FeaturesService/FinalizeUpgrade'].post"
+ update:
+ x-state: "Added in v26.2"
+ - target: "$.paths['/redpanda.core.admin.v2.FeaturesService/GetUpgradeStatus'].post"
+ update:
+ x-state: "Added in v26.2"
- target: "$.paths['/redpanda.core.admin.v2.IcebergService/GetIcebergStatus'].post"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| # 26.2 endpoints | |
| - target: "$.paths['/redpanda.core.admin.v2.IcebergService/GetIcebergStatus'].post" | |
| update: | |
| x-state: "Added in v26.2" | |
| # 26.2 endpoints | |
| - target: "$.paths['/redpanda.core.admin.v2.FeaturesService/FinalizeUpgrade'].post" | |
| update: | |
| x-state: "Added in v26.2" | |
| - target: "$.paths['/redpanda.core.admin.v2.FeaturesService/GetUpgradeStatus'].post" | |
| update: | |
| x-state: "Added in v26.2" | |
| - target: "$.paths['/redpanda.core.admin.v2.IcebergService/GetIcebergStatus'].post" | |
| update: | |
| x-state: "Added in v26.2" |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@admin/v2-overlays/add-endpoint-versioning.yaml` around lines 92 - 95, Extend
the v26.2 endpoint updates in the overlay to include the FeaturesService paths
for FinalizeUpgrade and GetUpgradeStatus, assigning each the same x-state value,
“Added in v26.2,” as the existing IcebergService endpoint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regenerate admin/admin-v2.yaml from redpanda core v26.2.1-rc4, which adds the IcebergService/GetIcebergStatus endpoint (and the FeaturesService endpoints that also landed in 26.2). Add an IcebergService tag description and an "Added in v26.2" version badge for the new endpoint.