Conversation
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
| ---- | ||
| iceberg_enabled: true | ||
| # Set a custom namespace instead of the default "redpanda" | ||
| iceberg_default_catalog_namespace: ["<custom-namespace>"] |
There was a problem hiding this comment.
@nvartolomei Based on the description for ENG-917 I included the property in this example without commenting it out or saying it's optional. Does that sound good, and should I also change the wording on 133 and be explicit that it's required?
There was a problem hiding this comment.
Is it strictly required @nvartolomei or just commonly needed because Glue uses a single catalog (or something like that) and so namespaces are the primary table isolation mechanism. Is that right?
There was a problem hiding this comment.
It is not required as we have a default BUT, I believe, you almost always want to set it to something unique as in Glue you get only 1 catalog so once you create second cluster you'll start getting conflicts.
This document should make this very clear to the user so they don't shoot themselves in the foot now or later.
This section:
By default, Redpanda creates Iceberg tables in a namespace called
redpanda. To use a custom namespace, set config_ref:iceberg_default_catalog_namespace,true,properties/cluster-properties[iceberg_default_catalog_namespace] at the same time. This property cannot be changed after Iceberg is enabled.
Suggested change by Claude:
The explanatory paragraph should be expanded to explain the multi-cluster / shared-catalog conflict risk explicitly. Something along the lines of:
"When multiple clusters write to the same catalog, each cluster must use a distinct namespace to avoid table name collisions. This is especially critical for catalog providers that offer a single global catalog per account (e.g., AWS Glue), where there is no other isolation mechanism."
Then, at each point where the user is prompted to enable Iceberg, the docs should actively prompt the user to evaluate whether a unique namespace is needed, with a cross-reference to the expanded rationale above.
|
@mattschumpert We added iceberg_default_catalog_namespace to the list of new properties in 25.3 What's New, but since it was added in a point release, we did not dedicate a whole entry to it. Should I add one in 26.1? |
| endif::[] | ||
| ifndef::env-cloud[] | ||
| + | ||
| By default, Redpanda creates Iceberg tables in a namespace called `redpanda`. To use a custom namespace, set config_ref:iceberg_default_catalog_namespace,true,properties/cluster-properties[`iceberg_default_catalog_namespace`] at the same time. This property cannot be changed after Iceberg is enabled. |
There was a problem hiding this comment.
Maybe say what 'enabled' means? (setting which conf)
| ---- | ||
| iceberg_enabled: true | ||
| # Set a custom namespace instead of the default "redpanda" | ||
| iceberg_default_catalog_namespace: ["<custom-namespace>"] |
There was a problem hiding this comment.
Is it strictly required @nvartolomei or just commonly needed because Glue uses a single catalog (or something like that) and so namespaces are the primary table isolation mechanism. Is that right?
Description
This pull request updates the Iceberg documentation to clarify how Redpanda manages Iceberg table namespaces, especially regarding the default namespace (
redpanda) and how to configure a custom namespace using theiceberg_default_catalog_namespaceproperty. The changes also improve instructions and examples across several integration guides to ensure users understand namespace behavior in both cloud and self-managed environments.NOTE: The property is still conditionalized out from Cloud docs
Key documentation improvements:
Namespace configuration and usage:
redpandanamespace by default and clarified how to set a custom namespace with theiceberg_default_catalog_namespaceproperty, including the important note that this property is immutable after enabling Iceberg. [1] [2] [3]<cluster-id>instead of<CLUSTER ID>). [1] [2]Integration-specific instructions and visibility:
redpandawith their configured namespace in query examples if a custom namespace is used.Resolves https://redpandadata.atlassian.net/browse/
Review deadline:
Page previews
About Iceberg Topics > Enable Iceberg integration
Query Iceberg Topics > Query examples
AWS Glue > Update cluster configuration
Checks